Repository navigation
fix(ignores): Remove partially overlapped emotes - #7224
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nerixyz
force-pushed
the
feat/gifs-2.5-of-n
branch
from
September 4, 2026 13:27
7662a23 to
901c106
Compare
Nerixyz
marked this pull request as ready for review
September 4, 2026 13:29
pajlada
approved these changes
Sep 4, 2026
Mm2PL
approved these changes
Sep 4, 2026
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
When an ignore-replace phrase starts in an emote, we didn't remove the special item. It's best illustrated by the tests. If we replace `pp` → `p` in `Kappa`, we didn't remove the emote even though it's no longer there. The same is (eventually) true for GIFs (Chatterino#7223 (comment)). This PR fixes that by removing all specials that overlap the removed range. Reviewed-by: pajlada <rasmus.karlsson@pajlada.com> Reviewed-by: Mm2PL <mm2pl+gh@kotmisia.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an ignore-replace phrase starts in an emote, we didn't remove the special item. It's best illustrated by the tests. If we replace
pp→pinKappa, we didn't remove the emote even though it's no longer there. The same is (eventually) true for GIFs (#7223 (comment)).This PR fixes that by removing all specials that overlap the removed range.
This is part of a stack
lengthfor Twitch specials #72202.5. fix(ignores): Remove partially overlapped emotes #7224 ← this one (not required for 3)