Repository navigation
refactor: Generalize Twitch emote parsing - #7219
Merged
Merged
Conversation
Nerixyz
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Sep 2, 2026
Mm2PL
approved these changes
Sep 2, 2026
This was referenced Sep 2, 2026
pajlada
approved these changes
Sep 4, 2026
pajlada
enabled auto-merge (squash)
September 4, 2026 11:30
VlaDexa
pushed a commit
to VlaDexa/chatterino7
that referenced
this pull request
Sep 9, 2026
Reviewed-by: Mm2PL <mm2pl+gh@kotmisia.pl> Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
Reviewed-by: Mm2PL <mm2pl+gh@kotmisia.pl> Reviewed-by: pajlada <rasmus.karlsson@pajlada.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gif in chat (#7186) are specified like emotes as a range of codepoints. We can reuse much of the code we have for Twitch emotes. This PR prepares us. It generalizes
TwitchEmoteOccurrenceinto aTwitchSpecialOccurrencethat holds a variant. To make the final diff easier, this is separated.This is part of a stack
lengthfor Twitch specials #7220