Repository navigation
fix: store length for Twitch specials - #7220
Merged
Merged
Conversation
Member
|
I think it would be clearer if we went for |
Nerixyz
force-pushed
the
feat/gifs-2-of-n
branch
from
September 2, 2026 10:42
5ce1a83 to
37c3bbf
Compare
Nerixyz
changed the title
end for specialslength for Twitch specials
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Sep 2, 2026
Nerixyz
force-pushed
the
feat/gifs-2-of-n
branch
from
September 2, 2026 17:26
37c3bbf to
0060c28
Compare
Nerixyz
marked this pull request as ready for review
September 4, 2026 12:20
pajlada
approved these changes
Sep 4, 2026
Mm2PL
approved these changes
Sep 4, 2026
VlaDexa
pushed a commit
to VlaDexa/chatterino7
that referenced
this pull request
Sep 9, 2026
Storing a length instead of an `end` makes more sense. We sometimes move the specials (e.g. in ignores). Both can be derived from each other. Reviewed-by: pajlada <rasmus.karlsson@pajlada.com> Reviewed-by: Mm2PL <mm2pl+gh@kotmisia.pl>
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
Storing a length instead of an `end` makes more sense. We sometimes move the specials (e.g. in ignores). Both can be derived from each other. Reviewed-by: pajlada <rasmus.karlsson@pajlada.com> Reviewed-by: Mm2PL <mm2pl+gh@kotmisia.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing a length instead of an
endmakes more sense. We sometimes move the specials (e.g. in ignores). Both can be derived from each other.This is part of a stack
lengthfor Twitch specials #7220 ← this one