Repository navigation
Allow Z-Wave devices without manufacturer and product ids - #821
Merged
joostlek merged 1 commit intoOct 27, 2026
Merged
Conversation
SmartThings leaves manufacturerId, productType and productId out of the zwave block for some devices, e.g. when secure inclusion failed (networkSecurityLevel ZWAVE_S0_FAILED). Since the fields were added as required, get_devices() fails for every location with such a device.
joostlek
approved these changes
Oct 27, 2026
joostlek
added
the
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Since #784 (released with Home Assistant 2026.10),
Zwave.manufacturer_id,product_typeandproduct_idare required. SmartThings leaves these keys out of thezwaveblock for some devices, for example when secure inclusion failed ("networkSecurityLevel": "ZWAVE_S0_FAILED").get_devices()then fails for the whole location:In Home Assistant this stops the SmartThings integration from setting up: home-assistant/core#184789.
The three fields are now
int | Nonewith a default ofNone.network_idis still required.I added
tests/fixtures/devices_19.jsonwith a Z-Wave device whosezwaveblock has the shape from the HA report (no manufacturer/product ids), added it totest_fetching_devices, and generated its snapshot. The test fails with the error above without the model change.Related issue (if applicable): home-assistant/core#184789
Checklist:
pytest: 113 passed; ruff, ruff format, mypy and prettier clean).coveragercallowedREADME.MDupdated (if necessary) (not needed)