Repository navigation
[13.x] Release the unique lock when dispatching a scheduled job fails - #62083
Merged
taylorotwell merged 2 commits intoOct 18, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A unique job scheduled with
Schedule::job()keeps its unique lock when pushing it to the queue fails. Once the queue is reachable again, the scheduler keeps skipping the job because the lock from the failed run is still held, and with the defaultuniqueForof 0 it never expires:Schedule::dispatchUniqueJobToQueue()acquires the lock and then dispatches the job, but nothing releases the lock if the dispatch throws. This is the same issue #62010 fixed fordispatch()and #62045 fixed for queued listeners, in the remaining place that acquires the lock itself.This releases the lock when dispatching throws and rethrows the exception, the same way as those two.