Repository navigation
[13.x] Release the unique lock when pushing a queued listener fails - #62045
Merged
taylorotwell merged 1 commit intoOct 15, 2026
Merged
taylorotwell merged 1 commit into
taylorotwell merged 1 commit into
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a unique queued listener is dispatched,
Dispatcher::queueHandler()acquires the unique lock before pushing it to the queue. If the push throws (queue database or redis is down) the lock is never released, so every dispatch after that is silently skiped untill the lock expires, even after the queue is back.Jobs already got this fix in #62010, this does the same for listeners. everything after the lock is acquired is wrapped so the lock gets released if anything throws, then the exeption is rethrown:
Added a test that use a failing queue connection, same as the one in #62010.