Repository navigation
Use node:24-slim instead of node:24.18.1-slim to get security updates - #3217
Conversation
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryChanges all four Node stages in
Reviews (1) · Last reviewed commit: "Use node:24-slim again instead of node:2..." · Reviewed by Greptile |
There was a problem hiding this comment.
ℹ️ No critical issues — one consistency note below.
Reviewed changes
- Unpins the base image: all four
FROM node:24.18.1-slimstages (base,aio_builder,cli,mcp) now use the floatingnode:24-slimtag, and the four "replace oncenodejs/node#65042is fixed" comments are removed.
The premise checks out. The 24.18.1 pin existed to dodge the Node 24.19 ObjectWrap-cleanup crash (karakeep#2989), and the underlying fixes shipped in v24.22.0 (src: keep global list of addon-provided cleanup hooks, #63985, and src: fix use-after-free in CleanupHookThunkRun, #65630). The #65042 backport named in the removed comments was closed unmerged, but the equivalent fixes landed through those commits, and node:24-slim currently resolves to v24.22.1 (the October 21 security release). So the floating tag carries both the crash fix and the security patches.
ℹ️ CI now runs an older Node than the image
tooling/github/setup/action.yml:10 still pins node-version: 24.18.1, which every test workflow (ci.yml, cli.yml, mcp.yml, sdk.yml, ios.yml, android.yml, extension.yml) consumes. This PR makes the container float to 24.22.x while CI stays on 24.18.1, so CI no longer exercises the runtime that ships and itself runs a build that predates the October 21 security release. Since the fix it was protecting against is in 24.22.0, CI could track 24.x too.
Technical details
# CI Node pin diverges from the container runtime
## Affected sites
- `tooling/github/setup/action.yml:10` — `node-version: 24.18.1`
- Consumed by `.github/workflows/ci.yml` (5 jobs), `cli.yml`, `mcp.yml`, `sdk.yml`, `ios.yml`, `android.yml`, `extension.yml`
## Context
The `24.18.1` pin was added alongside the Docker pin for karakeep#2989 (Node 24.19 ObjectWrap cleanup abort). Both were comment-documented as "until the fix ships". This PR lifts the Docker half only, leaving the CI half behind and creating a version skew that did not exist before.
## Required outcome
- CI and the shipped container track the same Node 24.x line, so tests catch regressions that only manifest on newer 24.x patches.
## Suggested approach (optional)
Bump `node-version` to `24.x` in `tooling/github/setup/action.yml`. This is out of the Dockerfile's scope and safe to defer, but worth doing in a follow-up now that the fix is released.deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏
Project516
left a comment
There was a problem hiding this comment.
I checked this against the sources.
- The four
FROMlines are the only uses of 24.18.1 indocker/Dockerfile. The stale comments about nodejs/node#65042 go away with them.docker/Dockerfile.devalready usesnode:24-alpine. - On Docker Hub,
node:24-slimandnode:24.22.1-slimpoint to the same index digest today (sha256:55fb5f5a527ea2c5c4a95f963e48ef90aa38c7b346054fdc8ee9957a2b55d205, pushed Oct 21).24.22.0-slimhas a different digest, so the floating tag now includes the security release. - The crash fix is in v24.22.0. The v24 changelog lists
abe1b673e9(keep global list of addon-provided cleanup hooks, #63985) and5570a84048(fix use-after-free in CleanupHookThunkRun, #65630). The #65042 backport was closed unmerged, but the same change shipped through the normal release. - The one place still on 24.18.1 is
tooling/github/setup/action.yml(node-version). Every test workflow uses it, so CI runs a Node that predates the Oct 21 release and differs from the image. That is fine as a follow-up.
The change is correct and complete for the Dockerfile.
|
Thanks @eriktews! |
|
I'll cut a 0.34.1 with the fix |
…➔ 0.34.1) (#2417) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/karakeep-app/karakeep](https://github.com/karakeep-app/karakeep) | minor | `0.33.2` → `0.34.1` | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/6) for more information. --- ### Release Notes <details> <summary>karakeep-app/karakeep (ghcr.io/karakeep-app/karakeep)</summary> ### [`v0.34.1`](https://github.com/karakeep-app/karakeep/releases/tag/v0.34.1): 0.34.1 [Compare Source](karakeep-app/karakeep@v0.34.0...v0.34.1) This is a security release on top of 0.34.0. The docker images move from the pinned `node:24.18.1-slim` back to `node:24-slim` (currently Node 24.22.1) to pick up the [October 2026 Node.js security releases](https://nodejs.org/en/blog/vulnerability/october-2026-security-releases). Among other fixes, these patch a Brotli decoder out-of-bounds write (CVE-2026-111497) and several TLS certificate hostname validation bypasses (CVE-2026-105483, CVE-2026-106069, CVE-2026-106072). Thanks [@​eriktews](https://github.com/eriktews) for the fix ([#​3217](karakeep-app/karakeep#3217))! The node version was pinned in 0.33.2 because of the better-sqlite3 crash loop ([#​2989](karakeep-app/karakeep#2989)). The upstream fix for that shipped in Node 24.22, so the pin is no longer needed. ### [`v0.34.0`](https://github.com/karakeep-app/karakeep/releases/tag/v0.34.0): 0.34.0 [Compare Source](karakeep-app/karakeep@v0.33.2...v0.34.0) ##### 0.34.0 Welcome to the `0.34.0` release of Karakeep (and sorry for the long wait)! The mobile app gets most of the attention this time: **Automatic offline downloads** for recent bookmarks and particular lists, **tablet layouts**, tag management, public lists, collaborators and attachments, all of which used to need the web app. The crawler got a big anti-bot overhaul: it now drives real **Google Chrome through patchright**, so far fewer sites will hand you a "Just a moment..." page instead of the article. There are also a lot of memory and performance improvements, along with tons of bug fixes. Thanks to everyone who contributed to this release: [@​justadityaraj](https://github.com/justadityaraj), [@​InventorB](https://github.com/InventorB), [@​ryanchou1994](https://github.com/ryanchou1994), [@​NoiceHax](https://github.com/NoiceHax), [@​0-0mfuji](https://github.com/0-0mfuji), [@​eriktews](https://github.com/eriktews), [@​qwist1233-cpu](https://github.com/qwist1233-cpu), [@​lightsabit](https://github.com/lightsabit), [@​BrownieCoder](https://github.com/BrownieCoder), [@​itz-puneet](https://github.com/itz-puneet), [@​jreiml](https://github.com/jreiml), [@​deepcfr](https://github.com/deepcfr), [@​mislav](https://github.com/mislav), [@​pradeepb28](https://github.com/pradeepb28), [@​Kyzcreig](https://github.com/Kyzcreig), [@​gowinder](https://github.com/gowinder), [@​samuel-sarmah](https://github.com/samuel-sarmah), and everyone who triaged bugs or shared feedback. *Note: the changes mentioned here for the extension and mobile releases will need to go through the different store (apple, google, mozilla) reviews. So it might take a couple of days until all of them are released.* > If you enjoy using Karakeep, consider supporting the project [here ☕️](https://buymeacoffee.com/mbassem) or via GitHub [here](https://github.com/sponsors/MohamedBassem). Also share Karakeep's managed offering (☁️ [link](https://cloud.karakeep.app)) with your friends who're not into selfhosting. <a href="https://www.buymeacoffee.com/mbassem" target="_blank"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Buy Me A Coffee" width="auto" height="50" ></a> ##### New Features 🚀 - **Karakeep's auth moved from next-auth to better-auth**: - This is an infrastructure change, but it's a big one. Karakeep moved its auth library to better-auth (away from next-auth). This will unlock a lot of new features in the future (e.g. 2fac, oauth login in the mobile app, hosted MCP auth, etc). - This migration is going to happen automatically after the upgrade BUT there are some caveats, please read the "Upgrading" section. - **Automatic Offline Downloads**: 0.33 let you save single bookmarks for offline reading on the mobile app. In this release, you can let karakeep automatically download recent bookmarks for you while the app is open, and also mark specific lists to be always fully available offline. - **Mobile app catching up with the web**: - Tablet layout showing multiple columns on wide screens. - Tag management: rename and delete tags from the app ([`fc401d0`](karakeep-app/karakeep@fc401d02)). - Manage public lists and list collaborators ([`292c13a`](karakeep-app/karakeep@292c13a5)). - View and download bookmark attachments ([`27774f9`](karakeep-app/karakeep@27774f97)). - A new usage statistics screen ([`6563ee1`](karakeep-app/karakeep@6563ee14)). - Pick a parent list, choose a list icon, and create lists straight from the "Manage Lists" page ([`7ca5ee2`](karakeep-app/karakeep@7ca5ee23), [`428d1f2`](karakeep-app/karakeep@428d1f22), [`f977712`](karakeep-app/karakeep@f9777128)). - **A crawler that gets blocked less**: - The crawler now drives the browser with [patchright](https://github.com/Kaliiiiiiiiii-Vinyzu/patchright), a Playwright fork that doesn't leak the automation signals that bot-protection scripts look for ([`af8b0eb`](karakeep-app/karakeep@af8b0eb0)). - The `karakeep-chrome` image now ships Google Chrome stable instead of Chrome Headless Shell, as protected sites block the headless shell far more often ([`ea57af1`](karakeep-app/karakeep@ea57af18)). This comes at the cost of the chrome image getting bigger unfortunatly. - The user agent now comes from the actual browser instead of a hardcoded Chrome 124 one ([`254174a`](karakeep-app/karakeep@254174ac)). - Cloudflare's "Just a moment..." and DataDome's device check clear on their own after a few seconds. The crawler now waits for them (up to `CRAWLER_CHALLENGE_WAIT_SEC`, default 15s) instead of saving the challenge page ([`1800346`](karakeep-app/karakeep@18003460)). - New `CRAWLER_BROWSER_TIMEZONE` to make the browser's timezone match your proxy's location, as a UTC browser behind a non-UTC proxy is a strong bot signal ([`ba8c188`](karakeep-app/karakeep@ba8c1885)). - **On-demand video preservation** ([#​3183](karakeep-app/karakeep#3183)): A new "Preserve Video" bookmark action downloads a single bookmark's video with yt-dlp. You can now keep automatic video downloads off and still preserve the ones you care about. - **Broken links management revamp** ([#​3105](karakeep-app/karakeep#3105)): The broken links settings page now groups issues by category and supports search, sorting, retrying and bulk deletion. - **Search**: New `has:notes` and `has:highlights` qualifiers by [@​BrownieCoder](https://github.com/BrownieCoder) ([#​3053](karakeep-app/karakeep#3053)). - **Others**: - New `CRAWLER_FULL_PAGE_ARCHIVE_MAX_SIZE_MB` to discard full-page archives above a certain size (media-heavy pages can produce 1GB+ archives that never render) by [@​NoiceHax](https://github.com/NoiceHax) ([#​3054](karakeep-app/karakeep#3054)). - Pages uploaded as precrawled archives (e.g. SingleFile uploads, and client-side crawling) now get a screenshot too ([#​3161](karakeep-app/karakeep#3161)). - Banner images are now resized and converted to WebP to save storage ([#​3165](karakeep-app/karakeep#3165)). - The default tagging model is now `gpt-6-luna` which costs half as much as `gpt-5.6-luna` used to cost (thanks OpenAI?). ##### UX Improvements ✨ - A visual refresh of various web app components. More modern looking dialogs, buttons, dropdown menus, tooltips, etc. - Added a "System" theme option that follows your OS by [@​deepcfr](https://github.com/deepcfr) ([#​3159](karakeep-app/karakeep#3159)). - The bookmark preview page now has the full bookmark options menu in its action bar ([`24fb655`](karakeep-app/karakeep@24fb655c)). - The "delete unused tags" button is now a bit more grown up ([`acbac6a`](karakeep-app/karakeep@acbac6ad)). - Home/End now move the cursor in the search bar by [@​eriktews](https://github.com/eriktews) ([#​3110](karakeep-app/karakeep#3110)). - The browser's theme color now follows dark mode by [@​itz-puneet](https://github.com/itz-puneet) ([#​3051](karakeep-app/karakeep#3051)). - Mobile: - Lists are sorted by name, like on the web, by [@​justadityaraj](https://github.com/justadityaraj) ([#​3040](karakeep-app/karakeep#3040)). - Bigger toolbar tap targets by [@​jreiml](https://github.com/jreiml) ([#​2813](karakeep-app/karakeep#2813)). - Better looking bookmark cards when there's no metadata ([`2b2771a`](karakeep-app/karakeep@2b2771a6)). ##### Fixes 🐛 - **Performance and memory**: - Fix a server memory leak caused by the query cache ([#​3138](karakeep-app/karakeep#3138)). - Workers and web only load the dependencies of features that are enabled cutting memory usage for most setups. You should expect a 40MB drop in RSS with this release. - Prometheus default metrics are no longer collected when Prometheus isn't configured ([#​2397](karakeep-app/karakeep#2397)). This fixes a regerssion introduced in 0.29 and should result into a lower baseline CPU usage. - Faster tag searches by [@​0-0mfuji](https://github.com/0-0mfuji) ([#​3089](karakeep-app/karakeep#3089)). - Search indexing now defaults to 50 workers (instead of 1) for better batching. Should result in faster indexing for large imports. - SQLite now runs `PRAGMA optimize` on open and daily ([`355a0b0`](karakeep-app/karakeep@355a0b09)). - Faster lists page and list stats queries and a smaller main web bundle ([`2d7cc4b`](karakeep-app/karakeep@2d7cc4bd), [`44ea028`](karakeep-app/karakeep@44ea0284), [`b640f15`](karakeep-app/karakeep@b640f15b)). - **Hardening**: - Upload body size is now enforced before parsing the multipart body ([`3e22b65`](karakeep-app/karakeep@3e22b659)). - Asset downloads now respect client backpressure instead of buffering in memory ([`b5cab5b`](karakeep-app/karakeep@b5cab5be)). - Pagination limits are now validated on all tRPC endpoints ([`94e1ea2`](karakeep-app/karakeep@94e1ea21)). - Content length is capped before tokenizing AI prompts ([`ef07e91`](karakeep-app/karakeep@ef07e913)). - Upgraded Next.js to 16.4.1 for its October security release ([#​3196](karakeep-app/karakeep#3196)). - Collaborators' bookmarks now show up in public lists by [@​NoiceHax](https://github.com/NoiceHax) ([#​3019](karakeep-app/karakeep#3019)). - Moving a list under one of its own sublists is now rejected, as the resulting cycle could send list deletion into an infinite loop. Reported by [@​Vertextheonesolution](https://github.com/Vertextheonesolution) (GHSA-892w-x93w-2fqp, [#​3199](karakeep-app/karakeep#3199)). - Fix bookmark pagination tie breakers that could skip or duplicate bookmarks ([`135f116`](karakeep-app/karakeep@135f1163)). - Fix the headers timeout for AI inference jobs with slow providers by [@​eriktews](https://github.com/eriktews) ([#​2888](karakeep-app/karakeep#2888)). - Fix embedding generation with providers that don't default to float embeddings ([#​3009](karakeep-app/karakeep#3009)). - Bookmarks deleted while being indexed no longer dangle in meilisearch ([`bca289d`](karakeep-app/karakeep@bca289d2)). - The RSS fetcher now identifies itself with a karakeep specific user agent ([`adf399b`](karakeep-app/karakeep@adf399be)). - If one of the workers fails, the whole worker process now crashes instead of silently running without it, so your container's restart policy can kick in ([`ae9e23b`](karakeep-app/karakeep@ae9e23b3)). - Fix `.jpg` uploads being rejected in the attachment box ([`2434e65`](karakeep-app/karakeep@2434e657)). - Fix the header shrinking in Safari ([`3c44114`](karakeep-app/karakeep@3c441143)). - Fix duplicate "sort by" in the all tags page ([`f5e56b4`](karakeep-app/karakeep@f5e56b42)). - Fix the sidebar's "+" (new list) button messing up the bookmark preview modal when clicked while a bookmark is open by [@​samuel-sarmah](https://github.com/samuel-sarmah) ([#​3192](karakeep-app/karakeep#3192)). - Make `/run` owned by `node` in the docker image so non-root setups work by [@​lightsabit](https://github.com/lightsabit) ([#​3114](karakeep-app/karakeep#3114)). - Mobile: - Fix lost and duplicated Android shares after the app gets killed ([`e7fbaab`](karakeep-app/karakeep@e7fbaab7)). This has been a long standing problem, and should signficantly improve share reliability for android. - Ignore Android's unreliable internet reachability checks that marked the app offline ([#​3127](karakeep-app/karakeep#3127)). - Fix the server save button getting hidden by the keyboard by [@​InventorB](https://github.com/InventorB) ([#​3010](karakeep-app/karakeep#3010)). - Markdown list bullets and numbers now use the foreground color by [@​ryanchou1994](https://github.com/ryanchou1994) ([#​3046](karakeep-app/karakeep#3046)). - Fix lists not getting auto refreshed when a bookmark is added to it ([`f4efff9`](karakeep-app/karakeep@f4efff99)) and vertical images in bookmark info ([`482369b`](karakeep-app/karakeep@482369b7)). - Fix a bug that was causing mobile API keys to not be revoked on mobile app logout ([`1820693`](karakeep-app/karakeep@1820693e)). - Added missing Turkish translations by [@​qwist1233-cpu](https://github.com/qwist1233-cpu) ([#​3111](karakeep-app/karakeep#3111)). ##### For Developers 🛠️ - The MCP server has been upgraded to the MCP v2 SDK ([`39df6c6`](karakeep-app/karakeep@39df6c6e)). - The CLI now bundles the official Karakeep skill ([`baf0b1b`](karakeep-app/karakeep@baf0b1bb)). - Karakeep now serves `/.well-known/api-catalog`, `/.well-known/change-password` and `/.well-known/security.txt` ([`2620d9e`](karakeep-app/karakeep@2620d9e6)). - The docs now have an `llms.txt` for agents ([`a8450b3`](karakeep-app/karakeep@a8450b3c)). - Translations have moved away from Weblate and to an LLM driven workflow. - Clarified `LOG_LEVEL` options in the docs by [@​mislav](https://github.com/mislav) ([#​3149](karakeep-app/karakeep#3149)). ##### Community Projects 💡 *Checkout our community projects page [here](https://docs.karakeep.app/community-projects).* - [Alfred Karakeep](https://github.com/Kyzcreig/alfred-karakeep): An Alfred workflow for inline bookmark search using Karakeep's query language by [@​Kyzcreig](https://github.com/Kyzcreig) ([#​2974](karakeep-app/karakeep#2974)). - [Supasend](https://supasend.app/#karakeep): A quick capture iOS app for sending photos and links to Karakeep by [@​pradeepb28](https://github.com/pradeepb28) ([#​3077](karakeep-app/karakeep#3077)). - [KaraClone](https://github.com/gowinder/karaclone): A reimplementation of the Karakeep server API that runs on the Cloudflare Workers free tier by [@​gowinder](https://github.com/gowinder) ([#​3124](karakeep-app/karakeep#3124)). ##### Screenshots 📸 ##### Automatic Offline Download <img width="603" height="1311" alt="Screenshot 2026-10-17 at 10 27 34 PM" src="https://github.com/user-attachments/assets/02f2344e-27ee-43d7-b8dd-d74fba936280" /> ##### Broken Links Page <img width="2402" height="1250" alt="Screenshot 2026-10-17 at 22 27 11@​2x" src="https://github.com/user-attachments/assets/0df7d9c9-63b5-4739-8e55-6135e95a14f1" /> ##### Upgrading 📦 **Things to know before upgrading:** - **Everyone gets signed out once.** The move to better-auth ([#​3140](karakeep-app/karakeep#3140)) switches web sessions from JWTs to database sessions, so all web users will need to sign in again. Mobile apps and API keys are not affected. - **Auth env changes**: - This release will automatically lowercase all email stored in the database (in prep for making email case insensitive), except accounts that will cause a conflict (two accounts that differ only in email case). You *Must* fix those conflicts before upgrading (by deleting the unused one). You'll get locked out if you have two conflicting accounts (neither of which are lowercase). If you get locked out, change the email address in the sqlite database to be lowercase to gain access back. - New `AUTH_TRUSTED_ORIGINS` (default `*`) to restrict which origins can sign in and be redirected to on top of `NEXTAUTH_URL`. - `NEXTAUTH_URL` and `NEXTAUTH_SECRET` keep their names and are still required. - **Migrate to the `karakeep-chrome` image if you haven't already.** Check the migration guide [here](https://docs.karakeep.app/administration/chrome-image-migration). Browserless (mostly unraid users) will continue to work but will miss out on the stealth improvements. It's advised to migrate to karakeep-chrome's unraid template maintained by [@​Collectathon](https://github.com/Collectathon). To upgrade: - If you're using KARAKEEP_VERSION=release, run `docker compose pull && docker compose up -d`. - If you're pinning it to a specific version, upgrade the version and then run `docker compose pull && docker compose up -d`. </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Rome) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNTEuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjE2Ny41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19--> Reviewed-on: https://git.aresu.eu/GiorgioAresu/home-ops/pulls/2417

Description
Use node:24-slim instead of node:24.18.1-slim in the
Dockerfileto get the most recent updates and security updates.Fixes # (issue)
This fixes the October 21st security updates for Node: https://nodejs.org/en/blog/vulnerability/october-2026-security-releases
Keep in mind that you may need to build the container with
--pullto make sure you get the latest version.How Has This Been Tested?
Manual tests on my own server
Checklist:
Please describe to which degree, if any, an LLM was used in creating this pull request.
Fully manual patch