[BrownieCoder]

Description

Add has:notes and has:highlights qualifiers to the search query language, including - and ! negation.

• Parse and validate the new matchers across the shared search types.
• Filter notes by non-null, non-empty values.
• Filter highlights with user-scoped EXISTS and NOT EXISTS queries.
• Support the qualifiers in smart lists, search autocomplete, and the query explainer.
• Document the new syntax and add parser, database, and smart-list coverage.

Fixes #3035

How Has This Been Tested?

• Shared test suite: 114 tests passed
• tRPC test suite: 453 tests passed
• Web test suite: 31 tests passed with TZ=UTC
• TypeScript --noEmit checks for shared, tRPC, and web
• Changed-file oxlint and oxfmt checks
• JSON parsing and git diff --check

Screenshots (if appropriate)

No screenshots required.

Checklist:

• I have carefully read CONTRIBUTING.md
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation if applicable
• I have no unrelated changes in the PR.
• I have confirmed that any new dependencies are strictly necessary.
• I have written tests for new code (if applicable)

Please describe to which degree, if any, an LLM was used in creating this pull request.

An LLM was used as a pair-programming tool to help draft the implementation and tests. I directed the scope, reviewed the behavior and final diff, and approved the change after the full test, type-check, lint, and formatting suites passed.

[greptile-apps]

Greptile Summary

This PR adds has:notes and has:highlights search qualifiers across parsing, validation, database filtering, smart lists, autocomplete, query explanations, documentation, and tests.

• Supports - and ! negation.
• Treats null and empty notes as absent.
• Uses user-scoped highlight existence checks.
• Adds parser, database, and smart-list coverage.

Confidence Score: 5/5

The PR appears safe to merge; the new qualifiers are consistently implemented across parser, schema, execution, smart-list, and web presentation paths.

No actionable correctness, security, or repository-rule failures remain after checking matcher consumers, parser behavior, database semantics, ownership boundaries, and UI integration.

Important Files Changed

Filename	Overview
packages/shared/searchQueryParser.ts	Extends qualifier lexing and parsing with note and highlight presence matchers, including negation and unsupported-value fallback.
packages/shared/types/search.ts	Adds both new leaf matcher variants to the shared recursive and non-recursive validation schemas.
packages/trpc/lib/search.ts	Implements user-scoped note and highlight filtering using direct predicates and correlated existence queries.
apps/web/components/dashboard/search/useSearchAutocomplete.ts	Adds positive and negated autocomplete entries for both qualifiers.
apps/web/components/dashboard/search/QueryExplainerTooltip.tsx	Explains positive and negative note and highlight matcher states.
packages/shared/searchQueryParser.test.ts	Covers supported qualifiers, both negation forms, unsupported values, and logical composition.
packages/trpc/lib/tests/search.test.ts	Covers empty-note behavior and user-scoped positive and negative highlight filtering.
packages/trpc/routers/lists.test.ts	Verifies that the new qualifiers work together in smart lists without crossing user boundaries.

_{Reviews (1): Last reviewed commit: "feat(search): add notes and highlights q..." | Re-trigger Greptile}

[MohamedBassem]

Thanks for the PR!

@pullfrog review

[pullfrog]

✅ No new issues found.

Reviewed changes

• Parser support for has:: Adds has to the qualifier lexer rule and maps has:notes / has:highlights to boolean matchers, honoring both - and ! negation; unknown has:* values remain free text.
• Shared matcher types: Adds zHasNotesMatcher / zHasHighlightsMatcher to both the non-recursive and lazy matcher unions.
• DB resolution: getIds filters notes on note IS NOT NULL AND note != '' (or the inverse), and highlights via a user-scoped correlated EXISTS / NOT EXISTS.
• Web surfaces: Adds autocomplete entries, query-explainer rows, and en / en_US translations.
• Docs and tests: Documents the qualifiers in docs/ and skills/SKILL.md, and adds parser, getBookmarkIdsFromMatcher, and smart-list integration coverage.

I verified the SQL is user-scoped on both bookmarks.userId and highlights.userId, and that the tests would fail if that scoping were dropped (the b4 other-user highlight case pins it). The parser's reconstruction of unknown has:* values as free text matches the existing is:/source: fallback behavior, so there is no regression for arbitrary has:-prefixed search terms.

  ^{｜ View workflow run ｜ Using DeepSeek Flash (free via Pullfrog for OSS) ｜ 𝕏}