Repository navigation
Fix pinned item duplication on clipboard re-read - #3480
Merged
Merged
Conversation
When a pinned item is activated, its data (including the
application/x-copyq-item-pinned metadata format) is placed on the system
clipboard. When clipboard ownership is later lost and the monitor re-reads
the clipboard, the data no longer contains mimePinned. The hash function
did not treat item metadata formats (item-pinned, item-notes) as plugin
formats, so the hash of the re-read data differed from the stored item
hash, causing addUnique() to create a duplicate.
Fix by widening isPluginFormat() to include all formats starting with the
plugin prefix ("application/x-copyq-item"), not just those without a dash
after "item". This makes hash() skip item metadata formats, so duplicate
detection works regardless of whether mimePinned is present.
Fixes: #3131
Fixes: #3042
Assisted-by: Claude (Anthropic)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3480 +/- ##
==========================================
+ Coverage 80.32% 80.44% +0.11%
==========================================
Files 243 243
Lines 30637 30658 +21
==========================================
+ Hits 24610 24663 +53
+ Misses 6027 5995 -32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pinned item is activated, its data (including the application/x-copyq-item-pinned metadata format) is placed on the system clipboard. When clipboard ownership is later lost and the monitor re-reads the clipboard, the data no longer contains mimePinned. The hash function did not treat item metadata formats (item-pinned, item-notes) as plugin formats, so the hash of the re-read data differed from the stored item hash, causing addUnique() to create a duplicate.
Fix by widening isPluginFormat() to include all formats starting with the plugin prefix ("application/x-copyq-item"), not just those without a dash after "item". This makes hash() skip item metadata formats, so duplicate detection works regardless of whether mimePinned is present.
Fixes: #3131
Fixes: #3042
Assisted-by: Claude (Anthropic)