Repository navigation
gtk: some bell features need to happen on receipt of every BEL - #8962
Merged
Merged
Conversation
Some bell features should be triggered on the receipt of every BEL character, namely `audio` and `system`. However, Ghostty was setting a boolean to `true` upon the receipt of the first BEL. Subsequent BEL characters would be ignored until that boolean was reset to `false`, usually by keyboard/mouse activity. This PR fixes the problem by ensuring that the `audio` and `system` features are triggered every time a BEL is received. Other features continue to be triggered only when the `bell-ringing` boolean state changes. Fixes ghostty-org#8957
mitchellh
force-pushed
the
gtk-bell-every-time
branch
from
September 30, 2025 13:40
0b55432 to
bdf0772
Compare
Contributor
|
This was totally good, I made some minor changes:
|
mitchellh
approved these changes
Sep 30, 2025
mitchellh
added a commit
that referenced
this pull request
Oct 6, 2025
Some bell features should be triggered on the receipt of every BEL character, namely `audio` and `system`. However, Ghostty was setting a boolean to `true` upon the receipt of the first BEL. Subsequent BEL characters would be ignored until that boolean was reset to `false`, usually by keyboard/mouse activity. This PR fixes the problem by ensuring that the `audio` and `system` features are triggered every time a BEL is received. Other features continue to be triggered only when the `bell-ringing` boolean state changes. Fixes #8957
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some bell features should be triggered on the receipt of every BEL character, namely
audioandsystem. However, Ghostty was setting a boolean totrueupon the receipt of the first BEL. Subsequent BEL characters would be ignored until that boolean was reset tofalse, usually by keyboard/mouse activity.This PR fixes the problem by ensuring that the
audioandsystemfeatures are triggered every time a BEL is received. Other features continue to be triggered only when thebell-ringingboolean state changes.Fixes #8957