Skip to content

GTK: quick-terminal-autohide breaks the quick terminal when manually toggled off #11679

Closed

Description

@pluiedev

See #11534.

Curiously, this manifests differently between different compositors. On KDE/KWin, the window simply turns blank. To restore the quick terminal one must first unfocus it and try to toggle it again.
image

On Niri the quick terminal is toggled off correctly, but then one must hit toggle twice to get it back open.

Given all this I'm assuming this is some sort of state inconsistency issue that simply nobody had run into before. I'm also not sure if this has been a long-standing issue or a recent regression from 1.3.x onwards.

Activity

  1. added this to the 1.3.2 milestone on Mar 20, 2026
  2. self-assigned this
    on Mar 20, 2026
  3. added
    gtkIssues exclusive to GTK which are not OS-specific
    on Mar 20, 2026
  4. added theissue type on Mar 20, 2026
  5. pluiedev commented on Mar 20, 2026

    @pluiedev
    MemberAuthor

    Confirmed this to be a problem on 1.2.x - then this probably never worked and I honestly wonder why I never caught it beforehand, lol

  6. dkinzler commented on Apr 15, 2026

    @dkinzler
    Contributor

    Not sure if you have figured this one out yet, but I gave it a look and found the bug causing this problem.

    The propIsActive function in apprt/gtk/class/window.zig, that is used to automatically hide the quick-terminal window when it becomes inactive, is also triggered when you manually hide the quick-terminal because when you hide the window it also becomes inactive. Normally that should just toggle the terminal off and immediately back on, but additionally there is a re-entrancy issue where gtk_widget_set_visible calls propIsActive which calls gtk_widget_set_visible again (through a chain of intermediary function calls). These nested calls to gtk_widget_set_visible mess up the GTK window state.
    I opened a vouch request #12272 with a more detailed explanation.

    The fix is to automatically hide the quick-terminal in propIsActive only if the window is inactive and visible.

  7. pluiedev commented on Aug 10, 2026

    @pluiedev
    MemberAuthor

    This was fixed in #12471 and never closed (somehow)

  8. modified the milestones: 1.3.2, 1.4.0 on Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

gtkIssues exclusive to GTK which are not OS-specific

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions