Fix quick-terminal breaking when manually toggling while autohide is enabled (#11679)

[dkinzler]

What do you want to change?

Hey, I've been wanting to get into open source for a while now, so I looked through the ghostty source code and some of the open issues, where I stumbled upon #11679 :

GTK: quick-terminal-autohide breaks the quick terminal when manually toggled off

After some debugging I found that there are two related issues causing this bug:

1. The quick-terminal-autohide feature is implemented via the Window.propIsActive event handler in src/apprt/gtk/class/window.zig, it is triggerd by GTK whenever a window becomes active/inactive. propIsActive checks (only) if the quick-terminal window is inactive and if so calls Window.toggleVisibility to hide it. When you manually hide the quick terminal it will cause the window to become inactive and thus run propIsActive, but the window is already not visible (Application.toggleQuickTerminal in src/apprt/gtk/class/application.zig already calls Window.toggleVisibility ), so propIsActive actually toggles it back on.
2. Normally 1. would just cause the quick-terminal to disappear and reappear immediately but the second problem is a nested/re-entrant call to gtk_widget_set_visible() in GTK. propIsActive is called from within gtk_widget_set_visible (via the event/signal system in GTK), propIsActive then calls (down the chain) gtk_widget_set_visible again (nested within the original call to gtk_widget_set_visible which has not yet returned). These nested calls cause the GTK window state to become corrupted, the window is marked visible, but is not really visible or just shows a placeholder, what exactly happens seems to depend on how the compositor handles moving the window focus)
   • the function call stack is Application.toggleQuickTerminal -> Window.toggleVisibility -> gtk_widget_set_visible (via self.as(gtk.Widget).isVisible -> ... (GTK event/signal handling) ... -> Window.propIsActive -> Windog.toggleVisiblity -> gtk_widget_set_visible

Not sure if that was a great explanation 😅, if not I can try to give a better one in the PR.

But the fix is to only autohide the quick-terminal in Window.propIsActive if the window is actually visible (add a check with self.as(gtk.Widget).isVisible() == 1 (see commit 2648668).

I reproduced the bug on KDE/hyprland and verified the fix on both.

Why do you want to make this change?

Fixes #11679

I acknowledge that:

• I have read the Contributing Guide and understand the contribution process.
• I have read and agree to follow the AI Usage Policy.
• I wrote this vouch request myself, in my own voice, without AI generating it.

[mitchellh]

!vouch