Repository navigation
Conversation
Member
Author
trybka
self-requested a review
September 15, 2026 18:04
trybka
approved these changes
Sep 15, 2026
There's references to this from bazel https://github.com/bazelbuild/bazel/blob/5604b553b2a54152e5e4f41ef4b01a416b7bfd44/tools/cpp/BUILD.tools#L44 We should remove both but in the meantime some rulesets reference this
keith
force-pushed
the
ks/add-back-grep-includes-alias
branch
from
September 15, 2026 18:14
5562948 to
ebc21b3
Compare
1 task
1 task
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Oct 6, 2026
tl;dr: that's in order to remove a local workaround thanks to: - bazelbuild/rules_cc#888. --- This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rules_cc](https://redirect.github.com/bazelbuild/rules_cc) | bazel_dep | patch | `0.2.25` → `0.2.26` | --- > [!WARNING] > Some dependencies could not be looked up. Check the [Dependency Dashboard](../issues/33469) for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_cc (rules_cc)</summary> ### [`v0.2.26`](https://redirect.github.com/bazelbuild/rules_cc/releases/tag/0.2.26) [Compare Source](https://redirect.github.com/bazelbuild/rules_cc/compare/0.2.25...0.2.26) #### Using bzlmod with Bazel 6 or later: 1. \[Bazel 6] Add `common --enable_bzlmod` to `.bazelrc`. 2. Add to your `MODULE.bazel` file: ```starlark bazel_dep(name = "rules_cc", version = "0.2.26") ``` #### Using WORKSPACE: ```starlark load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_cc", sha256 = "44a8f325fa2b5cfb0ecaddda4365b3374eeefa1f97309fdb9301abb0897dfa7a", strip_prefix = "rules_cc-0.2.26", url = "https://github.com/bazelbuild/rules_cc/releases/download/0.2.26/rules_cc-0.2.26.tar.gz", ) load("@rules_cc//cc:extensions.bzl", "compatibility_proxy_repo") compatibility_proxy_repo() ``` #### What's Changed ##### Notable changes - Split coverage features into `coverage_enabled` and `coverage_instrumented` ([#​842](https://redirect.github.com/bazelbuild/rules_cc/issues/842)) by [@​fmeum](https://redirect.github.com/fmeum) in [`8ab086b`](https://redirect.github.com/bazelbuild/rules_cc/commit/8ab086bef24031bf72b10fa49083c957616538dd) - Propagate the profile changelist when MemProf comes from an fdo_profile rule. by [@​a-googler](https://redirect.github.com/a-googler) in [`cd02576`](https://redirect.github.com/bazelbuild/rules_cc/commit/cd02576bfad2a205d6adbe8b9faa91871354e603) - Use compiler_files_without_includes for CcLtoBackendCompile actions. by [@​djasper-gh](https://redirect.github.com/djasper-gh) in [`33af48d`](https://redirect.github.com/bazelbuild/rules_cc/commit/33af48dd1b824139042140458a2fdbfb71628351) - Fix linkstamping in external repos ([#​840](https://redirect.github.com/bazelbuild/rules_cc/issues/840)) by [@​tobias17](https://redirect.github.com/tobias17) in [`aeab566`](https://redirect.github.com/bazelbuild/rules_cc/commit/aeab56621ea9f9c5c32797cb17c6e81dddd6627c) - Fix cc_shared_library dependencies being included in runfiles ([#​882](https://redirect.github.com/bazelbuild/rules_cc/issues/882)) by [@​keith](https://redirect.github.com/keith) in [`b712795`](https://redirect.github.com/bazelbuild/rules_cc/commit/b712795cb003ff8e8a7c457e719abc8b4ed68a99) - Fix cc_shared_library locations with rules_python on windows ([#​909](https://redirect.github.com/bazelbuild/rules_cc/issues/909)) by [@​keith](https://redirect.github.com/keith) in [`1f56261`](https://redirect.github.com/bazelbuild/rules_cc/commit/1f56261526d8f76f895221612c87f074fcbfe6b0) - Support checking command-line copts in disallowed copts policies by [@​a-googler](https://redirect.github.com/a-googler) in [`785f33a`](https://redirect.github.com/bazelbuild/rules_cc/commit/785f33a454363e5f8625d7f0c2265f254e7371fc) - Add back grep-includes alias ([#​888](https://redirect.github.com/bazelbuild/rules_cc/issues/888)) by [@​keith](https://redirect.github.com/keith) in [`eaafbd3`](https://redirect.github.com/bazelbuild/rules_cc/commit/eaafbd34240f0d0968f25782385cf013f823ea69) ##### Rules based toolchain changes - Set coverage_files from rules based toolchains ([#​904](https://redirect.github.com/bazelbuild/rules_cc/issues/904)) by [@​keith](https://redirect.github.com/keith) in [`59bedc6`](https://redirect.github.com/bazelbuild/rules_cc/commit/59bedc63681875c29b26d29b440f403fcdcb590d) **Full Changelog**: <bazelbuild/rules_cc@0.2.25...0.2.26> </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Paris) - Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday (`* 0-4,22-23 * * 1-5`) - Only on Sunday and Saturday (`* * * * 0,6`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/DataDog/datadog-agent). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzQuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjEzNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaGFuZ2Vsb2cvbm8tY2hhbmdlbG9nIiwiZGVwZW5kZW5jaWVzIiwiZGVwZW5kZW5jaWVzLWJhemVsIiwicWEvbm8tY29kZS1jaGFuZ2UiXX0=--> Co-authored-by: rdesgroppes <regis.desgroppes@datadoghq.com> Co-authored-by: dd-octo-sts[bot] <200755185+dd-octo-sts[bot]@users.noreply.github.com> Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's references to this from bazel https://github.com/bazelbuild/bazel/blob/5604b553b2a54152e5e4f41ef4b01a416b7bfd44/tools/cpp/BUILD.tools#L44
We should remove both but in the meantime some rulesets reference this