Skip to content

Fix cc_shared_library locations with rules_python on windows - #909

Closed
keith wants to merge 6 commits into
bazelbuild:mainfrom
keith:ks/fix-cc_shared_library-locations-with-rules_python-on-windows
Closed

keith wants to merge 6 commits into
bazelbuild:mainfrom
keith:ks/fix-cc_shared_library-locations-with-rules_python-on-windows

Conversation

@keith

@keith keith commented Sep 25, 2026

Copy link
Copy Markdown
Member

rules_python switched to using --enable_runfiles on windows which
revealed a bug that we weren't copying dependent dylibs for
cc_shared_library as we do for cc_binary.

rules_python switched to using --enable_runfiles on windows which
revealed a bug that we weren't copying dependent dylibs for
cc_shared_library as we do for cc_binary.
@keith
keith marked this pull request as ready for review September 25, 2026 18:30
@keith
keith requested a review from fmeum September 25, 2026 18:31
Comment thread MODULE.bazel Resolved
Co-authored-by: UebelAndre <github@uebelandre.com>
@trybka
trybka self-requested a review September 28, 2026 19:42
trybka
trybka previously approved these changes Sep 28, 2026
@keith keith added the P1 I'll work on this now. (Assignee required) label Sep 28, 2026
@keith
keith force-pushed the ks/fix-cc_shared_library-locations-with-rules_python-on-windows branch from 312a737 to a91965c Compare September 28, 2026 21:45
@keith

keith commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

ok it seems like that permissions zip thing was because the zip file came from the cache, and this has been fixed in rules_python 2.0+ by removing that feature all together. green again

@keith
keith force-pushed the ks/fix-cc_shared_library-locations-with-rules_python-on-windows branch from 2507296 to 40b44b6 Compare September 29, 2026 01:13
Comment thread .bazelrc Resolved
@keith
keith requested a review from trybka September 29, 2026 16:07
@trybka

trybka commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

so this merged and there is a different permissions error?

@keith
keith deleted the ks/fix-cc_shared_library-locations-with-rules_python-on-windows branch November 16, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 I'll work on this now. (Assignee required)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants