Repository navigation
fix(ui): add explicit types to terminalStore callbacks - #750
Merged
Merged
Conversation
The Zustand store callbacks for setPaused, setActiveTab, openTerminal, and setShowTerminal relied on type inference from the TerminalState interface, but tsc flagged them as implicit `any` during the npm publish build step. Add explicit parameter types. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kovtcharov-amd
approved these changes
Apr 11, 2026
1 task
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 11, 2026
## Summary - Fixes the `Publish to npm` job failure: https://github.com/amd/gaia/actions/runs/24279365243/job/70899004478 - **Root cause:** `npm publish` triggers `prepublishOnly` → `tsc && vite build`, but the job installs only production deps (`--omit=dev`). `tsc` fails because `@types/react`, `typescript`, etc. are missing. - **Fix:** Add `--ignore-scripts` to `npm publish`. The dist/ is already pre-built in the `build-npm` job and downloaded as an artifact — the prepublishOnly rebuild is redundant. > Fix #5 for the v0.17.2 publish pipeline, after #747 (YAML indent), #748 (permissions), #749 (macOS signing), #750 (terminalStore types). ## Test plan - [ ] Merge, move tag, verify npm publish succeeds 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish to npmjob: https://github.com/amd/gaia/actions/runs/24279178148/job/70898457497terminalStore.tscallbacks (setPaused,setActiveTab,openTerminal,setShowTerminal) relied on Zustand type inference for parameter types, buttscflagged them as implicitanyduring the buildTerminalStateinterfaceTest plan
npx tsc --noEmitpasses locally with zero errors🤖 Generated with Claude Code