Repository navigation
fix(ci): indent heredoc in publish.yml to fix startup_failure - #747
Merged
Merged
Conversation
The heredoc content in the github-release job's "Extract release notes" step was at column 0, breaking out of the `run: |` YAML block scalar. The YAML parser interpreted `- **Windows**` as a sequence item with `*Windows` as an alias reference, causing a startup_failure before any job could run (0 jobs, instant failure). Fix: indent the heredoc body to 10 spaces (matching the block scalar's indentation level). YAML strips the leading spaces, so bash still receives the content at column 0. Fixes: https://github.com/amd/gaia/actions/runs/24267844380 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kovtcharov-amd
approved these changes
Apr 11, 2026
1 task
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 11, 2026
…748) ## Summary - Fixes the `startup_failure` on the Publish Release workflow: https://github.com/amd/gaia/actions/runs/24278877956 - **Root cause:** `build-electron-apps.yml` declares `permissions: contents: write` at its top level. When called as a reusable workflow from `publish.yml`, the calling `build-electron` job only had `contents: read` (inherited from publish.yml's workflow-level permissions). GitHub Actions validates this at startup and rejects the run before any jobs start. - **Fix:** Add explicit `permissions: contents: write` to the `build-electron` job in publish.yml so it matches what the reusable workflow declares. > **Note:** The previous PR #747 fixed a YAML block scalar issue (heredoc indentation) that was also causing a parse error. This PR fixes the second startup_failure — the permissions mismatch discovered from the GitHub Actions error annotation. ## Test plan - [ ] Merge, move v0.17.2 tag, verify Publish Release workflow starts and reaches the Validate step 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 of 2 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 11, 2026
## Summary - Fixes the macOS DMG build failure in the Publish Release workflow: https://github.com/amd/gaia/actions/runs/24278980001 - **Root cause:** electron-builder auto-skips code signing for PR builds (`Current build is a part of pull request, code signing will be skipped`) but NOT for tag pushes. Without valid signing secrets, it tries to sign with empty credentials and fails with `⨯ .../src/gaia/apps/webui not a file`. - **Fix:** Pass `--config.mac.identity=null` when `APPLE_ID` is not set, explicitly telling electron-builder to skip signing. Windows and Linux builds are unaffected (they don't attempt signing without their respective secrets). > This is the third fix for the v0.17.2 publish pipeline, after #747 (YAML heredoc indentation) and #748 (reusable workflow permissions). ## Test plan - [x] The PR itself triggers `build-installers.yml` (via `paths:` filter) — the macOS job will validate the fix - [ ] After merge, move v0.17.2 tag and re-trigger publish 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 11, 2026
## Summary - Fixes the `Publish to npm` job failure: https://github.com/amd/gaia/actions/runs/24279365243/job/70899004478 - **Root cause:** `npm publish` triggers `prepublishOnly` → `tsc && vite build`, but the job installs only production deps (`--omit=dev`). `tsc` fails because `@types/react`, `typescript`, etc. are missing. - **Fix:** Add `--ignore-scripts` to `npm publish`. The dist/ is already pre-built in the `build-npm` job and downloaded as an artifact — the prepublishOnly rebuild is redundant. > Fix #5 for the v0.17.2 publish pipeline, after #747 (YAML indent), #748 (permissions), #749 (macOS signing), #750 (terminalStore types). ## Test plan - [ ] Merge, move tag, verify npm publish succeeds 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish Releaseworkflow failed withstartup_failure(0 jobs, instant failure) on the v0.17.2 tag push: https://github.com/amd/gaia/actions/runs/24267844380github-releasejob's "Extract release notes" step was at column 0 (no indentation), which broke out of therun: |YAML block scalar. The YAML parser interpreted- **Windows**as a sequence item with*Windowsas an alias reference, causing a parse error before any job could start.Test plan
yaml-lintpasses onpublish.yml(was failing before the fix)workflow_dispatch) to verify the publish workflow starts successfully🤖 Generated with Claude Code