Skip to content

[Linux] Fixed crash when navigating between tools - #1259

Merged
veler merged 1 commit into
mainfrom
fixed-crash-linux
Jun 25, 2024
Merged

veler merged 1 commit into
mainfrom
fixed-crash-linux

Conversation

@veler

@veler veler commented Jun 22, 2024

Copy link
Copy Markdown
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #1194, #1234

What is the new behavior?

Rewrote the whole blazor web view on Linux. The implementation is now much closer from MacOS one, which will help with maintainability. However the rewrite itself doesn't address the crash issue. The crash is solved by creating a message pump when the web browser wants to send a message.

Other information

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS
    • Linux

@veler
veler requested a review from btiteux June 22, 2024 17:34
@veler
veler merged commit 08a556a into main Jun 25, 2024
@veler
veler deleted the fixed-crash-linux branch June 25, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank screen on Ubuntu 22.04 App Randomly Triggers Exceptions Between Page Loads

1 participant