Repository navigation
feat: rework highlights & their UI - #6695
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pajlada
force-pushed
the
feat/highlights-gui
branch
from
January 18, 2026 13:01
72e7693 to
3144ac0
Compare
4 tasks done
pajlada
added
the
hold for release
pajlada
removed
the
hold for release
pajlada
force-pushed
the
feat/highlights-gui
branch
3 times, most recently
from
April 11, 2026 10:29
7619c99 to
d9b661f
Compare
pajlada
force-pushed
the
feat/highlights-gui
branch
4 times, most recently
from
April 25, 2026 10:20
416a95b to
ca3bb7d
Compare
pajlada
force-pushed
the
feat/highlights-gui
branch
9 times, most recently
from
May 2, 2026 13:11
c038a8c to
f17a84b
Compare
pajlada
force-pushed
the
feat/highlights-gui
branch
2 times, most recently
from
May 9, 2026 10:20
00a0a5b to
210716b
Compare
pajlada
force-pushed
the
feat/highlights-gui
branch
from
May 16, 2026 09:39
8bb9bc4 to
eaf5071
Compare
pajlada
force-pushed
the
feat/highlights-gui
branch
3 times, most recently
from
May 24, 2026 09:37
0c84e7e to
57885ed
Compare
pajlada
force-pushed
the
feat/highlights-gui
branch
from
June 6, 2026 09:43
3fd2b4f to
14ffe60
Compare
Since the highlight can be modified both from the configure dialog and from the list of highlights, we need to prevent both from happening at the same time to avoid spaghetti.
For the highlighting model, I would like to keep the width of everything _except_ the name/highlight trigger static.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rebuilds highlights to a fully user-customizable solution.
Users can now:
Things that would be nice for future expansions:
Known issues
TODO: Make these into GitHub issues
Breaking changes
A lot of highlight-related messages have had their flags changed. If you use filters based on some of these flags, things might be different.
The highlight order of messages is preserved in a best-effort state. With this change, you will now be able to fully customize the order highlights are checked in, so move things around to fit your use-case.
If you had a custom "Default sound", that was not migrated with this change, and you will need to individually set your custom sound on highlights.
The "Highlight inline whispers" setting is now completely controlled by the "Inline whispers" highlight being enabled or disabled
Other notable things
"Ignore Highlights" is more potent, as more things are highlights. If a user shares their subscription and you ignore their highlights, that message won't be colored for you.
Fixes #3472
Fixes #3865
Fixes #3872
Fixes #4191
Fixes #5285
Partially fixes #3616 (highlights only, not ignores)
Fixes #2365 through the use of filter highlights. Not super UX-friendly, but it gets the job done.
Fixes #2401 through the use of filter highlights.
Fixes #2124 - the checkboxes are not there and configuration is done in a dialog instead.
Fixes #3710 by allowing a filter highlight.
Things I think should be fixed in a follow-up PR:
#5360
#6524
#2157
#3584 - some groundwork has been laid for it in this PR, but leaving it for a follow-up.
#6794
If I mark a comment as resolved and I'm wrong, send a new message or make a new "thread", as I hide everything that's resolved.
Images