Repository navigation
fix: set windows.h definitions on WIN32 instead of MSVC - #6534
Merged
Merged
Conversation
4 tasks done
pajlada
approved these changes
Nov 1, 2025
pajlada
enabled auto-merge (squash)
November 1, 2025 11:01
Pietro228
pushed a commit
to Stream-Ally/streamally-chatterino
that referenced
this pull request
Dec 5, 2025
Pietro228
pushed a commit
to Stream-Ally/streamally-chatterino
that referenced
this pull request
Dec 5, 2025
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
babicekmarek
pushed a commit
to babicekmarek/streamally-chatterino
that referenced
this pull request
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
-DNOMINMAXto be conditional onWIN32instead ofMSVCand adds-DWIN32_LEAN_AND_MEAN. The latter was always set when using PCH (throughnonstd/expected.h).We assumed that compiling on Windows implies
MSVC, but that's not always the case, as you can use other compilers that aren't/don't simulate MSVC. Although this is unsupported/untested from our side, we can at least fix trivial errors like this.Fixes #6533.