Skip to content

Possible def leak in headers using windows.h #6533

Closed

Description

@solomoncyj

Checklist

  • I'm reporting a problem with Chatterino
  • I've verified that I'm running the most recent nightly build or stable release
  • I've looked for my problem on the wiki
  • I've searched the issues and pull requests for similar looking reports

Describe your issue

[0/2] Re-checking globbed directories...
[136/489] Automatic MOC and UIC for target chatterino-lib
AutoMoc: C:/Users/solom/Downloads/chatterino2/src/util/UnixSignalHandler.hpp: note: No relevant classes found. No output generated.
[265/489] Building CXX object src/CMakeFiles/chatterino-lib.dir/messages/layouts/MessageLayoutElement.cpp.obj
C:/Users/solom/Downloads/chatterino2/src/messages/layouts/MessageLayoutElement.cpp:483:70: warning: implicit conversion from 'char16_t' to 'char32_t' may change the meaning of the represented code unit [-Wcharacter-conversion]
  483 |             if (text.size() > i + 1 && QChar::isLowSurrogate(text[i].unicode()))
      |                                        ~~~~~                 ~~~~~~~~^~~~~~~~~
1 warning generated.
[271/489] Building CXX object src/CMakeFiles/chatterino-lib.dir/messages/MessageElement.cpp.obj
C:/Users/solom/Downloads/chatterino2/src/messages/MessageElement.cpp:739:67: warning: implicit conversion from 'char16_t' to 'char32_t' may change the meaning of the represented code unit [-Wcharacter-conversion]
  739 |                                    QChar::isHighSurrogate(word[i].unicode());
      |                                    ~~~~~                  ~~~~~~~~^~~~~~~~~
1 warning generated.
[310/489] Building CXX object src/CMakeFiles/chatterino-lib.dir/providers/bttv/BttvLiveUpdates.cpp.obj
FAILED: src/CMakeFiles/chatterino-lib.dir/providers/bttv/BttvLiveUpdates.cpp.obj
C:\bin\ccache.exe C:\LLVM\bin\clang++.exe -DAB_CUSTOM_SETTINGS -DCHATTERINO -DCHATTERINO_HAVE_PLUGINS -DIRC_NAMESPACE=Communi -DIRC_STATIC -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0x060403 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_SVG_LIB -DQT_WARN_DEPRECATED_UP_TO=0x060403 -DQT_WIDGETS_LIB -DSOL_ALL_SAFETIES_ON=1 -DSOL_NO_NIL=0 -DSOL_USING_CXX_LUA=1 -DUNICODE -DUSEWINSDK -DWIN32 -DWIN64 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_UNICODE -D_WIN32_WINNT=0x0A00 -D_WIN64 -IC:/Users/solom/Downloads/chatterino2/build/src/chatterino-lib_autogen/include -IC:/Users/solom/Downloads/chatterino2/src -IC:/Users/solom/Downloads/chatterino2/build/autogen -IC:/Users/solom/Downloads/chatterino2/lib/semver/include -IC:/Users/solom/Downloads/chatterino2/lib/expected-lite/include -IC:/Users/solom/Downloads/chatterino2/lib/miniaudio -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcCore -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcModel -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcUtil -IC:/Users/solom/Downloads/chatterino2/lib/settings/include -IC:/Users/solom/Downloads/chatterino2/lib/twitch-eventsub-ws/src/../include -IC:/Users/solom/Downloads/chatterino2/lib/lua/src -IC:/Users/solom/Downloads/chatterino2/lib/qtkeychain/qtkeychain/.. -IC:/Users/solom/Downloads/chatterino2/build/lib/qtkeychain/qtkeychain -IC:/Users/solom/Downloads/chatterino2/lib/WinToast/include -isystem C:/include/QtCore -isystem C:/include -isystem C:/mkspecs/win32-clang-msvc -isystem C:/include/QtWidgets -isystem C:/include/QtGui -isystem C:/include/QtNetwork -isystem C:/include/QtSvg -isystem C:/include/QtConcurrent -isystem C:/Users/solom/Downloads/chatterino2/lib/serialize/include -isystem C:/Users/solom/Downloads/chatterino2/lib/signals/include -isystem C:/Users/solom/Downloads/chatterino2/lib/rapidjson/include -isystem C:/Users/solom/Downloads/chatterino2/lib/websocketpp -isystem C:/Users/solom/Downloads/chatterino2/lib/lrucache -isystem C:/Users/solom/Downloads/chatterino2/lib/magic_enum/include -isystem C:/include/boost-1_89 -isystem C:/Users/solom/Downloads/chatterino2/lib/certify/include -isystem C:/Users/solom/Downloads/chatterino2/lib/sol2/include -march=native -flto=thin -Os -DNDEBUG -std=gnu++20 -D_DLL -D_MT -Xclang --dependent-lib=msvcrt -Wall -Wno-unused-function -Wno-switch -Wno-deprecated-declarations -Wno-sign-compare -Wno-strict-aliasing -Werror=return-type -Werror=reorder -Wno-unused-local-typedef -Wno-unused-private-field -Werror=inconsistent-missing-override -Werror=final-dtor-non-final-class -Werror=ambiguous-reversed-operator -Wno-unused-variable -Xclang -include-pch -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx.pch -Xclang -include -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx -MD -MT src/CMakeFiles/chatterino-lib.dir/providers/bttv/BttvLiveUpdates.cpp.obj -MF src\CMakeFiles\chatterino-lib.dir\providers\bttv\BttvLiveUpdates.cpp.obj.d -o src/CMakeFiles/chatterino-lib.dir/providers/bttv/BttvLiveUpdates.cpp.obj -c C:/Users/solom/Downloads/chatterino2/src/providers/bttv/BttvLiveUpdates.cpp
In file included from C:/Users/solom/Downloads/chatterino2/src/providers/bttv/BttvLiveUpdates.cpp:1:
In file included from C:/Users/solom/Downloads/chatterino2/src\providers/bttv/BttvLiveUpdates.hpp:5:
C:/Users/solom/Downloads/chatterino2/src\providers/liveupdates/BasicPubSubManager.hpp:253:39: error: expected unqualified-id
  253 |         auto pendingSubsToTake = std::min(this->pendingSubscriptions_.size(),
      |                                       ^
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\minwindef.h:197:29: note: expanded from macro 'min'
  197 | #define min(a,b)            (((a) < (b)) ? (a) : (b))
      |                             ^
1 error generated.
[321/489] Building CXX object src/CMakeFiles/chatterino-lib.dir/providers/seventv/SeventvEventAPI.cpp.obj
FAILED: src/CMakeFiles/chatterino-lib.dir/providers/seventv/SeventvEventAPI.cpp.obj
C:\bin\ccache.exe C:\LLVM\bin\clang++.exe -DAB_CUSTOM_SETTINGS -DCHATTERINO -DCHATTERINO_HAVE_PLUGINS -DIRC_NAMESPACE=Communi -DIRC_STATIC -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0x060403 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_SVG_LIB -DQT_WARN_DEPRECATED_UP_TO=0x060403 -DQT_WIDGETS_LIB -DSOL_ALL_SAFETIES_ON=1 -DSOL_NO_NIL=0 -DSOL_USING_CXX_LUA=1 -DUNICODE -DUSEWINSDK -DWIN32 -DWIN64 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_UNICODE -D_WIN32_WINNT=0x0A00 -D_WIN64 -IC:/Users/solom/Downloads/chatterino2/build/src/chatterino-lib_autogen/include -IC:/Users/solom/Downloads/chatterino2/src -IC:/Users/solom/Downloads/chatterino2/build/autogen -IC:/Users/solom/Downloads/chatterino2/lib/semver/include -IC:/Users/solom/Downloads/chatterino2/lib/expected-lite/include -IC:/Users/solom/Downloads/chatterino2/lib/miniaudio -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcCore -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcModel -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcUtil -IC:/Users/solom/Downloads/chatterino2/lib/settings/include -IC:/Users/solom/Downloads/chatterino2/lib/twitch-eventsub-ws/src/../include -IC:/Users/solom/Downloads/chatterino2/lib/lua/src -IC:/Users/solom/Downloads/chatterino2/lib/qtkeychain/qtkeychain/.. -IC:/Users/solom/Downloads/chatterino2/build/lib/qtkeychain/qtkeychain -IC:/Users/solom/Downloads/chatterino2/lib/WinToast/include -isystem C:/include/QtCore -isystem C:/include -isystem C:/mkspecs/win32-clang-msvc -isystem C:/include/QtWidgets -isystem C:/include/QtGui -isystem C:/include/QtNetwork -isystem C:/include/QtSvg -isystem C:/include/QtConcurrent -isystem C:/Users/solom/Downloads/chatterino2/lib/serialize/include -isystem C:/Users/solom/Downloads/chatterino2/lib/signals/include -isystem C:/Users/solom/Downloads/chatterino2/lib/rapidjson/include -isystem C:/Users/solom/Downloads/chatterino2/lib/websocketpp -isystem C:/Users/solom/Downloads/chatterino2/lib/lrucache -isystem C:/Users/solom/Downloads/chatterino2/lib/magic_enum/include -isystem C:/include/boost-1_89 -isystem C:/Users/solom/Downloads/chatterino2/lib/certify/include -isystem C:/Users/solom/Downloads/chatterino2/lib/sol2/include -march=native -flto=thin -Os -DNDEBUG -std=gnu++20 -D_DLL -D_MT -Xclang --dependent-lib=msvcrt -Wall -Wno-unused-function -Wno-switch -Wno-deprecated-declarations -Wno-sign-compare -Wno-strict-aliasing -Werror=return-type -Werror=reorder -Wno-unused-local-typedef -Wno-unused-private-field -Werror=inconsistent-missing-override -Werror=final-dtor-non-final-class -Werror=ambiguous-reversed-operator -Wno-unused-variable -Xclang -include-pch -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx.pch -Xclang -include -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx -MD -MT src/CMakeFiles/chatterino-lib.dir/providers/seventv/SeventvEventAPI.cpp.obj -MF src\CMakeFiles\chatterino-lib.dir\providers\seventv\SeventvEventAPI.cpp.obj.d -o src/CMakeFiles/chatterino-lib.dir/providers/seventv/SeventvEventAPI.cpp.obj -c C:/Users/solom/Downloads/chatterino2/src/providers/seventv/SeventvEventAPI.cpp
In file included from C:/Users/solom/Downloads/chatterino2/src/providers/seventv/SeventvEventAPI.cpp:1:
In file included from C:/Users/solom/Downloads/chatterino2/src\providers/seventv/SeventvEventAPI.hpp:4:
C:/Users/solom/Downloads/chatterino2/src\providers/liveupdates/BasicPubSubManager.hpp:253:39: error: expected unqualified-id
  253 |         auto pendingSubsToTake = std::min(this->pendingSubscriptions_.size(),
      |                                       ^
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\minwindef.h:197:29: note: expanded from macro 'min'
  197 | #define min(a,b)            (((a) < (b)) ? (a) : (b))
      |                             ^
1 error generated.
[323/489] Building CXX object src/CMakeFiles/chatterino-lib.dir/providers/twitch/PubSubManager.cpp.obj
FAILED: src/CMakeFiles/chatterino-lib.dir/providers/twitch/PubSubManager.cpp.obj
C:\bin\ccache.exe C:\LLVM\bin\clang++.exe -DAB_CUSTOM_SETTINGS -DCHATTERINO -DCHATTERINO_HAVE_PLUGINS -DIRC_NAMESPACE=Communi -DIRC_STATIC -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0x060403 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_SVG_LIB -DQT_WARN_DEPRECATED_UP_TO=0x060403 -DQT_WIDGETS_LIB -DSOL_ALL_SAFETIES_ON=1 -DSOL_NO_NIL=0 -DSOL_USING_CXX_LUA=1 -DUNICODE -DUSEWINSDK -DWIN32 -DWIN64 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_UNICODE -D_WIN32_WINNT=0x0A00 -D_WIN64 -IC:/Users/solom/Downloads/chatterino2/build/src/chatterino-lib_autogen/include -IC:/Users/solom/Downloads/chatterino2/src -IC:/Users/solom/Downloads/chatterino2/build/autogen -IC:/Users/solom/Downloads/chatterino2/lib/semver/include -IC:/Users/solom/Downloads/chatterino2/lib/expected-lite/include -IC:/Users/solom/Downloads/chatterino2/lib/miniaudio -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcCore -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcModel -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcUtil -IC:/Users/solom/Downloads/chatterino2/lib/settings/include -IC:/Users/solom/Downloads/chatterino2/lib/twitch-eventsub-ws/src/../include -IC:/Users/solom/Downloads/chatterino2/lib/lua/src -IC:/Users/solom/Downloads/chatterino2/lib/qtkeychain/qtkeychain/.. -IC:/Users/solom/Downloads/chatterino2/build/lib/qtkeychain/qtkeychain -IC:/Users/solom/Downloads/chatterino2/lib/WinToast/include -isystem C:/include/QtCore -isystem C:/include -isystem C:/mkspecs/win32-clang-msvc -isystem C:/include/QtWidgets -isystem C:/include/QtGui -isystem C:/include/QtNetwork -isystem C:/include/QtSvg -isystem C:/include/QtConcurrent -isystem C:/Users/solom/Downloads/chatterino2/lib/serialize/include -isystem C:/Users/solom/Downloads/chatterino2/lib/signals/include -isystem C:/Users/solom/Downloads/chatterino2/lib/rapidjson/include -isystem C:/Users/solom/Downloads/chatterino2/lib/websocketpp -isystem C:/Users/solom/Downloads/chatterino2/lib/lrucache -isystem C:/Users/solom/Downloads/chatterino2/lib/magic_enum/include -isystem C:/include/boost-1_89 -isystem C:/Users/solom/Downloads/chatterino2/lib/certify/include -isystem C:/Users/solom/Downloads/chatterino2/lib/sol2/include -march=native -flto=thin -Os -DNDEBUG -std=gnu++20 -D_DLL -D_MT -Xclang --dependent-lib=msvcrt -Wall -Wno-unused-function -Wno-switch -Wno-deprecated-declarations -Wno-sign-compare -Wno-strict-aliasing -Werror=return-type -Werror=reorder -Wno-unused-local-typedef -Wno-unused-private-field -Werror=inconsistent-missing-override -Werror=final-dtor-non-final-class -Werror=ambiguous-reversed-operator -Wno-unused-variable -Xclang -include-pch -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx.pch -Xclang -include -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx -MD -MT src/CMakeFiles/chatterino-lib.dir/providers/twitch/PubSubManager.cpp.obj -MF src\CMakeFiles\chatterino-lib.dir\providers\twitch\PubSubManager.cpp.obj.d -o src/CMakeFiles/chatterino-lib.dir/providers/twitch/PubSubManager.cpp.obj -c C:/Users/solom/Downloads/chatterino2/src/providers/twitch/PubSubManager.cpp
C:/Users/solom/Downloads/chatterino2/src/providers/twitch/PubSubManager.cpp:338:14: error: expected unqualified-id
  338 |         std::min(this->requests.size(), PubSubClient::MAX_LISTENS);
      |              ^
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\minwindef.h:197:29: note: expanded from macro 'min'
  197 | #define min(a,b)            (((a) < (b)) ? (a) : (b))
      |                             ^
1 error generated.
[325/489] Building CXX object src/CMakeFiles/chatterino-lib.dir/providers/twitch/TwitchIrcServer.cpp.obj
FAILED: src/CMakeFiles/chatterino-lib.dir/providers/twitch/TwitchIrcServer.cpp.obj
C:\bin\ccache.exe C:\LLVM\bin\clang++.exe -DAB_CUSTOM_SETTINGS -DCHATTERINO -DCHATTERINO_HAVE_PLUGINS -DIRC_NAMESPACE=Communi -DIRC_STATIC -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0x060403 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_SVG_LIB -DQT_WARN_DEPRECATED_UP_TO=0x060403 -DQT_WIDGETS_LIB -DSOL_ALL_SAFETIES_ON=1 -DSOL_NO_NIL=0 -DSOL_USING_CXX_LUA=1 -DUNICODE -DUSEWINSDK -DWIN32 -DWIN64 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_UNICODE -D_WIN32_WINNT=0x0A00 -D_WIN64 -IC:/Users/solom/Downloads/chatterino2/build/src/chatterino-lib_autogen/include -IC:/Users/solom/Downloads/chatterino2/src -IC:/Users/solom/Downloads/chatterino2/build/autogen -IC:/Users/solom/Downloads/chatterino2/lib/semver/include -IC:/Users/solom/Downloads/chatterino2/lib/expected-lite/include -IC:/Users/solom/Downloads/chatterino2/lib/miniaudio -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcCore -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcModel -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcUtil -IC:/Users/solom/Downloads/chatterino2/lib/settings/include -IC:/Users/solom/Downloads/chatterino2/lib/twitch-eventsub-ws/src/../include -IC:/Users/solom/Downloads/chatterino2/lib/lua/src -IC:/Users/solom/Downloads/chatterino2/lib/qtkeychain/qtkeychain/.. -IC:/Users/solom/Downloads/chatterino2/build/lib/qtkeychain/qtkeychain -IC:/Users/solom/Downloads/chatterino2/lib/WinToast/include -isystem C:/include/QtCore -isystem C:/include -isystem C:/mkspecs/win32-clang-msvc -isystem C:/include/QtWidgets -isystem C:/include/QtGui -isystem C:/include/QtNetwork -isystem C:/include/QtSvg -isystem C:/include/QtConcurrent -isystem C:/Users/solom/Downloads/chatterino2/lib/serialize/include -isystem C:/Users/solom/Downloads/chatterino2/lib/signals/include -isystem C:/Users/solom/Downloads/chatterino2/lib/rapidjson/include -isystem C:/Users/solom/Downloads/chatterino2/lib/websocketpp -isystem C:/Users/solom/Downloads/chatterino2/lib/lrucache -isystem C:/Users/solom/Downloads/chatterino2/lib/magic_enum/include -isystem C:/include/boost-1_89 -isystem C:/Users/solom/Downloads/chatterino2/lib/certify/include -isystem C:/Users/solom/Downloads/chatterino2/lib/sol2/include -march=native -flto=thin -Os -DNDEBUG -std=gnu++20 -D_DLL -D_MT -Xclang --dependent-lib=msvcrt -Wall -Wno-unused-function -Wno-switch -Wno-deprecated-declarations -Wno-sign-compare -Wno-strict-aliasing -Werror=return-type -Werror=reorder -Wno-unused-local-typedef -Wno-unused-private-field -Werror=inconsistent-missing-override -Werror=final-dtor-non-final-class -Werror=ambiguous-reversed-operator -Wno-unused-variable -Xclang -include-pch -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx.pch -Xclang -include -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx -MD -MT src/CMakeFiles/chatterino-lib.dir/providers/twitch/TwitchIrcServer.cpp.obj -MF src\CMakeFiles\chatterino-lib.dir\providers\twitch\TwitchIrcServer.cpp.obj.d -o src/CMakeFiles/chatterino-lib.dir/providers/twitch/TwitchIrcServer.cpp.obj -c C:/Users/solom/Downloads/chatterino2/src/providers/twitch/TwitchIrcServer.cpp
In file included from C:/Users/solom/Downloads/chatterino2/src/providers/twitch/TwitchIrcServer.cpp:14:
In file included from C:/Users/solom/Downloads/chatterino2/src\providers/bttv/BttvLiveUpdates.hpp:5:
C:/Users/solom/Downloads/chatterino2/src\providers/liveupdates/BasicPubSubManager.hpp:253:39: error: expected unqualified-id
  253 |         auto pendingSubsToTake = std::min(this->pendingSubscriptions_.size(),
      |                                       ^
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\minwindef.h:197:29: note: expanded from macro 'min'
  197 | #define min(a,b)            (((a) < (b)) ? (a) : (b))
      |                             ^
1 error generated.
[326/489] Building CXX object src/CMakeFiles/chatterino-lib.dir/providers/twitch/TwitchChannel.cpp.obj
FAILED: src/CMakeFiles/chatterino-lib.dir/providers/twitch/TwitchChannel.cpp.obj
C:\bin\ccache.exe C:\LLVM\bin\clang++.exe -DAB_CUSTOM_SETTINGS -DCHATTERINO -DCHATTERINO_HAVE_PLUGINS -DIRC_NAMESPACE=Communi -DIRC_STATIC -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0x060403 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_KEYWORDS -DQT_SVG_LIB -DQT_WARN_DEPRECATED_UP_TO=0x060403 -DQT_WIDGETS_LIB -DSOL_ALL_SAFETIES_ON=1 -DSOL_NO_NIL=0 -DSOL_USING_CXX_LUA=1 -DUNICODE -DUSEWINSDK -DWIN32 -DWIN64 -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_UNICODE -D_WIN32_WINNT=0x0A00 -D_WIN64 -IC:/Users/solom/Downloads/chatterino2/build/src/chatterino-lib_autogen/include -IC:/Users/solom/Downloads/chatterino2/src -IC:/Users/solom/Downloads/chatterino2/build/autogen -IC:/Users/solom/Downloads/chatterino2/lib/semver/include -IC:/Users/solom/Downloads/chatterino2/lib/expected-lite/include -IC:/Users/solom/Downloads/chatterino2/lib/miniaudio -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcCore -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcModel -IC:/Users/solom/Downloads/chatterino2/lib/libcommuni/include/IrcUtil -IC:/Users/solom/Downloads/chatterino2/lib/settings/include -IC:/Users/solom/Downloads/chatterino2/lib/twitch-eventsub-ws/src/../include -IC:/Users/solom/Downloads/chatterino2/lib/lua/src -IC:/Users/solom/Downloads/chatterino2/lib/qtkeychain/qtkeychain/.. -IC:/Users/solom/Downloads/chatterino2/build/lib/qtkeychain/qtkeychain -IC:/Users/solom/Downloads/chatterino2/lib/WinToast/include -isystem C:/include/QtCore -isystem C:/include -isystem C:/mkspecs/win32-clang-msvc -isystem C:/include/QtWidgets -isystem C:/include/QtGui -isystem C:/include/QtNetwork -isystem C:/include/QtSvg -isystem C:/include/QtConcurrent -isystem C:/Users/solom/Downloads/chatterino2/lib/serialize/include -isystem C:/Users/solom/Downloads/chatterino2/lib/signals/include -isystem C:/Users/solom/Downloads/chatterino2/lib/rapidjson/include -isystem C:/Users/solom/Downloads/chatterino2/lib/websocketpp -isystem C:/Users/solom/Downloads/chatterino2/lib/lrucache -isystem C:/Users/solom/Downloads/chatterino2/lib/magic_enum/include -isystem C:/include/boost-1_89 -isystem C:/Users/solom/Downloads/chatterino2/lib/certify/include -isystem C:/Users/solom/Downloads/chatterino2/lib/sol2/include -march=native -flto=thin -Os -DNDEBUG -std=gnu++20 -D_DLL -D_MT -Xclang --dependent-lib=msvcrt -Wall -Wno-unused-function -Wno-switch -Wno-deprecated-declarations -Wno-sign-compare -Wno-strict-aliasing -Werror=return-type -Werror=reorder -Wno-unused-local-typedef -Wno-unused-private-field -Werror=inconsistent-missing-override -Werror=final-dtor-non-final-class -Werror=ambiguous-reversed-operator -Wno-unused-variable -Xclang -include-pch -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx.pch -Xclang -include -Xclang C:/Users/solom/Downloads/chatterino2/build/src/CMakeFiles/chatterino-lib.dir/cmake_pch.hxx -MD -MT src/CMakeFiles/chatterino-lib.dir/providers/twitch/TwitchChannel.cpp.obj -MF src\CMakeFiles\chatterino-lib.dir\providers\twitch\TwitchChannel.cpp.obj.d -o src/CMakeFiles/chatterino-lib.dir/providers/twitch/TwitchChannel.cpp.obj -c C:/Users/solom/Downloads/chatterino2/src/providers/twitch/TwitchChannel.cpp
In file included from C:/Users/solom/Downloads/chatterino2/src/providers/twitch/TwitchChannel.cpp:22:
In file included from C:/Users/solom/Downloads/chatterino2/src\providers/bttv/BttvLiveUpdates.hpp:5:
C:/Users/solom/Downloads/chatterino2/src\providers/liveupdates/BasicPubSubManager.hpp:253:39: error: expected unqualified-id
  253 |         auto pendingSubsToTake = std::min(this->pendingSubscriptions_.size(),
      |                                       ^
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\minwindef.h:197:29: note: expanded from macro 'min'
  197 | #define min(a,b)            (((a) < (b)) ? (a) : (b))
      |                             ^
C:/Users/solom/Downloads/chatterino2/src/providers/twitch/TwitchChannel.cpp:1504:18: error: expected unqualified-id
 1504 |             std::min(static_cast<int>(secondsSinceDisconnect + 1) * 10, limit);
      |                  ^
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\minwindef.h:197:29: note: expanded from macro 'min'
  197 | #define min(a,b)            (((a) < (b)) ? (a) : (b))
      |                             ^
2 errors generated.

Screenshots

No response

OS and Chatterino Version

4be0e13 , win 11

Activity

  1. changed the title [-]Possible def leak in headers incuding `windows.h`[/-] [+]Possible def leak in headers using `windows.h`[/+] on Oct 9, 2025
  2. Nerixyz commented on Oct 9, 2025

    @Nerixyz
    Contributor

    C:\LLVM\bin\clang++.exe

    Although this might work today, it's an unsupported configuration. This runs Clang with the GCC options. Since the fix here should be simple, I opened #6534.

    If you're already using Clang, you can use clang-cl. This is the same compiler, but the frontend simulates that of MSVC1. Notably, CMake will have MSVC set to true.
    You can enable this in CMake by setting -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl when configuring.

    Footnotes

    1. CMake should also use lld-link in that case. â†Đ

  3. added and removed
    issue-reportAn issue reported by a user.
    on Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions