Repository navigation
Search space restriction - #1125
Merged
Merged
Conversation
rudy-6-4
reviewed
Oct 28, 2024
rudy-6-4
left a comment
rudy-6-4
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Let's see with real implem.
aPere3
force-pushed
the
alex/optimizer_tfhers
branch
from
October 31, 2024 15:54
6db7910 to
266da78
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: f70a18b | Previous: 09894b6 | Ratio |
|---|---|---|---|
v0 PBS table generation |
53763602 ns/iter (± 521216) |
53863508 ns/iter (± 965902) |
1.00 |
v0 PBS simulate dag table generation |
38420347 ns/iter (± 525977) |
38423465 ns/iter (± 390678) |
1.00 |
v0 WoP-PBS table generation |
52198086 ns/iter (± 282530) |
52551878 ns/iter (± 494024) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
aPere3
force-pushed
the
alex/optimizer_tfhers
branch
2 times, most recently
from
November 7, 2024 14:02
8796b5d to
d540e48
Compare
aPere3
changed the title
aPere3
force-pushed
the
alex/optimizer_tfhers
branch
from
November 7, 2024 14:07
d540e48 to
6e35b76
Compare
aPere3
force-pushed
the
alex/optimizer_tfhers
branch
2 times, most recently
from
November 12, 2024 14:39
fca910d to
0fccfbf
Compare
BourgerieQuentin
approved these changes
Nov 13, 2024
Member
|
cc @jdmarsh the API you do will change with this PR |
aPere3
force-pushed
the
alex/optimizer_tfhers
branch
3 times, most recently
from
November 14, 2024 13:38
3849f7c to
09894b6
Compare
aPere3
force-pushed
the
alex/optimizer_tfhers
branch
from
November 14, 2024 13:44
09894b6 to
f70a18b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.