Repository navigation
Document benchmarking - #1053
Conversation
024d015 to
065e933
Compare
yuxizama
left a comment
yuxizama
left a comment
There was a problem hiding this comment.
Some suggestions, thanks!
065e933 to
b906721
Compare
yuxizama
left a comment
yuxizama
left a comment
There was a problem hiding this comment.
Thank you so much @umut-sahin
bcm-at-zama
left a comment
bcm-at-zama
left a comment
There was a problem hiding this comment.
Thx @umut-sahin.
Should we have either another .md for the tests of examples, or an update to have explanations here for tests? I don't mean explaining pytest, but more, what's the philosophy with the classes, like what you had mentioned to me in #1040 (comment) (even if I don't fully agree here)
b906721 to
acf9b3a
Compare
acf9b3a to
5179c17
Compare
|
Benchmark list is removed and branch is rebased on main. Can I get another review, so that if it's okay, we can merge! |
|
I'll review soon |
|
Having a look |
bcm-at-zama
left a comment
bcm-at-zama
left a comment
There was a problem hiding this comment.
Thanks @umut-sahin
Asking for a few last modifs, after the new test-notebooks. Also, having you've done this, I think it would be nice to ask @yuxizama to review the new .md. (That's why it's better to ask her to review only when the tech team is ok)
5179c17 to
6e07feb
Compare
bcm-at-zama
left a comment
bcm-at-zama
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @umut-sahin
No description provided.