Repository navigation
fix(frontend): remove unnecessary signed conversions - #1047
Merged
Merged
Conversation
Contributor
|
Thx @umut-sahin |
BourgerieQuentin
approved these changes
Sep 13, 2024
umut-sahin
force-pushed
the
fix/unnecessary-signedness-conversion
branch
from
September 13, 2024 13:25
e819415 to
819d600
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that we consider clear values as signed, so if one were to do,
x @ ywhere x is encrypted uintx and y is clear uinty, x would be converted to signed, which is not necessary.