Repository navigation
Recover deleted session working directories - #375
Merged
Merged
Conversation
Co-authored-by: yottacode <325888353+yottacode-agent@users.noreply.github.com>
Co-authored-by: yottacode <325888353+yottacode-agent@users.noreply.github.com>
Owner
Author
|
Follow-up fixes applied:
Verification: |
Co-authored-by: yottacode <325888353+yottacode-agent@users.noreply.github.com>
Owner
Author
|
Additional correctness fix pushed in
Verification passed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover gracefully when the session's working directory is deleted or removed, such as when an active worktree is cleaned up externally.
Cwd recovery is centralized at tool dispatch and remains session-local. It updates the shared
CwdRef, emits oneCwdChangedevent with recovery details, and prevents mutating tools from silently executing in the fallback directory. Read-only tools continue using explicit session cwd paths. Recovery does not call process-globalos.Chdir, avoiding cross-session cwd races.Related issue
Not linked.
How was this tested?
go test -race ./internal/agent ./internal/tuigo test ./...go vet ./...All passed.
Checklist
go test ./...passesgo vet ./...is cleangovulncheck ./...reports no reachable vulnerabilitiesDrafted with yottacode
Drafted with yottacode