Skip to content

Polish approval modal layout - #339

Merged
yottadynamics merged 2 commits into
mainfrom
worktree-peppy-leaping-dolphin
Sep 12, 2026
Merged

yottadynamics merged 2 commits into
mainfrom
worktree-peppy-leaping-dolphin

Conversation

@yottadynamics

Copy link
Copy Markdown
Owner

Summary

Redesigns the approval modal into a cleaner, aligned decision card.

  • Moves Approval needed and the tool name inside the modal content
  • Uses one shared indentation gutter for the header, preview, hints, and choices
  • Adds intentional spacing before the preview and approval actions
  • Preserves viewport height handling for long previews

How was this tested?

  • go test ./internal/tui
  • go vet ./internal/tui
  • LSP diagnostics for changed Go files

All passed. LSP reports only the existing informational note about the unused compatibility helper approvalHotkeyGrid.

Checklist

  • Tests added or updated
  • Docs updated — no documentation changes needed for this visual-only TUI refinement
  • PR is focused on one logical change

Drafted with yottacode

yottadynamics and others added 2 commits September 12, 2026 00:27
Co-authored-by: yottacode <325888353+yottacode-agent@users.noreply.github.com>
Co-authored-by: yottacode <325888353+yottacode-agent@users.noreply.github.com>
@yottadynamics

Copy link
Copy Markdown
Owner Author

Follow-up fix for Ubuntu -race failure:

  • Captures the browser-launch function when constructing the OAuth handler, avoiding the test-mutated package-global function being read from a background goroutine.
  • Waits for the callback handler to finish writing its HTTP response before the fetcher closes the callback server, preventing intermittent EOF responses.

Verification:

  • go test ./internal/mcp
  • go test -race ./internal/mcp
  • go test -race ./...

All pass locally.

@yottadynamics
yottadynamics merged commit 3b7e202 into main Sep 12, 2026
7 checks passed
@yottadynamics
yottadynamics deleted the worktree-peppy-leaping-dolphin branch September 12, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant