Skip to content

Fix lazy sandbox profile recovery - #238

Merged
yottadynamics merged 1 commit into
mainfrom
worktree-document-sandbox-lifecycle
Aug 27, 2026
Merged

yottadynamics merged 1 commit into
mainfrom
worktree-document-sandbox-lifecycle

Conversation

@yottadynamics

Copy link
Copy Markdown
Owner

Summary

  • Add lazy config reload before starting sandbox profiles that are not live yet, so fixing [sandbox].documents_image mid-session lets the next document subprocess attempt use the corrected image without rebuilding the tool registry.
  • Keep already-live profile containers stable, fail closed if the backend changes, and serialize concurrent first use of the same profile so duplicate Podman containers cannot race on the same deterministic name.
  • Update /sandbox detection to check Podman plus both default/documents images, block enabling sandbox mode when Podman is missing or detection has not completed, and warn (not block) when images are missing locally because Podman can pull on first use.
  • Update sandbox/document docs to describe documents_image, lazy profile recovery, and the no-host-fallback failure contract.

Related issue

Closes #226

How was this tested?

  • go test ./internal/agentruntime ./internal/tui
  • go test ./...
  • go vet ./...
  • govulncheck ./...
  • Read-only review subagent found three issues; fixed all three before final verification:
    • serialized concurrent first-use profile startup
    • installed the config reloader for dispatch worker sandbox managers
    • blocked /sandbox persistence before Podman detection completes

Checklist

  • go test ./... passes
  • go vet ./... is clean
  • govulncheck ./... reports no reachable vulnerabilities
  • Tests added or updated — a new capability ships with tests, a bug fix ships with a regression test
  • Docs updated in the same change if behavior or surface changed (relevant docs/ guide)
  • PR is focused on one logical change

@yottadynamics
yottadynamics force-pushed the worktree-document-sandbox-lifecycle branch from 39c6f57 to 472d4d8 Compare August 27, 2026 02:46
@yottadynamics
yottadynamics merged commit 7718810 into main Aug 27, 2026
7 checks passed
@yottadynamics
yottadynamics deleted the worktree-document-sandbox-lifecycle branch August 27, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mid-session sandbox image switching

1 participant