Skip to content

Revert clear hero reset to avoid mouse lag - #234

Merged
yottadynamics merged 1 commit into
mainfrom
fix-clear-terminal-lag
Aug 26, 2026
Merged

yottadynamics merged 1 commit into
mainfrom
fix-clear-terminal-lag

Conversation

@yottadynamics

Copy link
Copy Markdown
Owner

Summary

Reverts the PR #223 behavior that made /clear reset enteredConversation=false and return to the live launch hero.

That behavior restored welcome-card hover after /clear, but it also re-enabled MouseModeAllMotion for the fresh session. In Bubble Tea, all-motion mode reports idle mouse movement, and every message goes through the serial Update + render loop. After /clear, normal mouse movement could therefore queue repeated welcome-hover updates ahead of keystrokes and make typing feel laggy.

This returns /clear to the safer static welcome-card behavior: the startup card is appended once into the transcript, enteredConversation remains one-way, and the post-clear view stays in MouseModeCellMotion instead of all-motion. The hover-after-clear regression is intentionally accepted until the hero hover path can be redesigned without a global all-motion flood.

Related issue

Follow-up to reverted #223.

How was this tested?

  • go test ./internal/tui -run 'TestHero_StaysExitedAfterClear|TestClear_AppendsStaticWelcomeWithoutAllMotionMouse|TestView_EnablesAllMotionForWelcomeBeforeConversationStarts' — passes
  • go test ./internal/tui — passes
  • go test ./... — passes
  • go vet ./... — clean

Note: LSP diagnostics reported stale syntax diagnostics for internal/tui/commands.go and internal/tui/hero_test.go after edits even though gofmt, targeted tests, package tests, full tests, and go vet all pass.

Checklist

  • go test ./... passes
  • go vet ./... is clean
  • govulncheck ./... reports no reachable vulnerabilities
  • Tests added or updated — a new capability ships with tests, a bug fix ships with a regression test
  • Docs updated in the same change if behavior or surface changed (not applicable; internal TUI regression fix)
  • PR is focused on one logical change

@yottadynamics
yottadynamics merged commit f299625 into main Aug 26, 2026
7 checks passed
@yottadynamics
yottadynamics deleted the fix-clear-terminal-lag branch August 26, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant