Repository navigation
Revert clear hero reset to avoid mouse lag - #234
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the PR #223 behavior that made
/clearresetenteredConversation=falseand return to the live launch hero.That behavior restored welcome-card hover after
/clear, but it also re-enabledMouseModeAllMotionfor the fresh session. In Bubble Tea, all-motion mode reports idle mouse movement, and every message goes through the serial Update + render loop. After/clear, normal mouse movement could therefore queue repeated welcome-hover updates ahead of keystrokes and make typing feel laggy.This returns
/clearto the safer static welcome-card behavior: the startup card is appended once into the transcript,enteredConversationremains one-way, and the post-clear view stays inMouseModeCellMotioninstead of all-motion. The hover-after-clear regression is intentionally accepted until the hero hover path can be redesigned without a global all-motion flood.Related issue
Follow-up to reverted #223.
How was this tested?
go test ./internal/tui -run 'TestHero_StaysExitedAfterClear|TestClear_AppendsStaticWelcomeWithoutAllMotionMouse|TestView_EnablesAllMotionForWelcomeBeforeConversationStarts'— passesgo test ./internal/tui— passesgo test ./...— passesgo vet ./...— cleanNote: LSP diagnostics reported stale syntax diagnostics for
internal/tui/commands.goandinternal/tui/hero_test.goafter edits even thoughgofmt, targeted tests, package tests, full tests, andgo vetall pass.Checklist
go test ./...passesgo vet ./...is cleangovulncheck ./...reports no reachable vulnerabilities