Skip to content

Update music metadata 6.1.0 - #1772

Merged
Borewit merged 5 commits into
masterfrom
greenkeeper/music-metadata-6.1.0
Jan 8, 2020
Merged

Borewit merged 5 commits into
masterfrom
greenkeeper/music-metadata-6.1.0

Conversation

@Borewit

@Borewit Borewit commented Jan 6, 2020 •

Copy link
Copy Markdown
Member

Update dependency to music-metadata v6.1.0

Changes:

  1. Update call to parseStream with IFileInfo, to adopt to music-metadata v6 API
  2. If the parsing of the file (or torrent stream) has completed, send a final update event with metadata.
  3. Renamed promise onMetaData to onMetadata
  4. Add additional audio extensions (which mostly helps to determine if torrent is audio torrent):
extension Description
.m2a MPEG-1 Layer 2 Audio File
.mka Matroska audio
.mpc Musepack
.wv WavePack

@hicom150 hicom150 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

🎉 Awesome work @Borewit 🎉

@Borewit
Borewit force-pushed the greenkeeper/music-metadata-6.1.0 branch from ef29ff2 to 38aef81 Compare January 8, 2020 18:59
@Borewit
Borewit merged commit 6f2aa86 into master Jan 8, 2020
@Borewit
Borewit deleted the greenkeeper/music-metadata-6.1.0 branch January 8, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants