[314eter]

What is the purpose of this pull request?

• Documentation update
• Bug fix
• New feature
• Other, please explain:

What changes did you make?

PR #1498 fixed issue #1652 for downloadPath and torrentsFolderPath, but not for externalPlayerPath. I changed the default value to "".

Is there anything you'd like reviewers to focus on?

I handled existing config files that have externalPlayerPath = null by changing this to "" when loading the config file. It's not a beautiful solution, but otherwise they have to edit it by hand.

[welcome]

🙌 Thanks for opening this pull request! You're awesome.

[mathiasvr]

Hi, thanks for looking into this.

I wonder how it can be partially fixed, maybe it does not work for the other paths as well?

I think we should allow externalPlayerPath to still be null, and handle the cases where it is not allowed.
If this is the same error as #1652, I think we should add an appropriate null check in the path-selector component instead.

[314eter]

The other paths are not set to null when a new config file is created.

[mathiasvr]

I see, so maybe setting it to undefined fixes it as well?
I still think we should handle it in the path-selector though, I can look into it later, unless you’re up for it? 😉

[mathiasvr]

Okay, I have opened #1704 to handle the null's in the path-selector component.

However, we should still consider changing the default externalPlayerPath to a string type.

[feross]

The correct way to handle old configuration values is by adding an entry to the migrations.js file to "upgrade" the user's config when they update to a new version of the app. This way, we can handle the migration in one place. Then, throughout the rest of the codebase we can just assume that the configuration file has the new format. So, in this case, we could just assume that saved.prefs.externalPlayerPath will always be a string going forward :)

[314eter]

I added the migration, assuming the next version will be 0.21.1.

[hicom150]

LGTM 👍

[feross]

LGTM

[welcome]

🎉 Congrats on getting your first pull request landed!