[hicom150]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

Given that we have recently added electron-installer-debian it is straightforward to add electron-installer-redhat and add rpm file creation support.

Is there anything you'd like reviewers to focus on?

It would be nice if someone with Fedora could check if the generated package works as expected 😅

Related:

• .rpm package for Fedora, etc #1502 .rpm package for Fedora, etc

[Borewit]

I would expect that this command only builds the rpm, but the target platform is still all

npm run package linux ---platform=rpm

[Borewit]

• Update README needs to describe the rpm package target.

• Succeed to build rpm

• Succeed to install rpm

• Succeed run installed wetorrent-desktop, via Gnome desktop

[feross]

@Borewit npm run package linux ---platform=rpm

The command to use is npm run package -- linux --package=rpm.

[feross]

This change generally looks good to me. I'd like to wait to merge this until after my PR #1696 is merged. Then, I'd like this to be updated to support building an .rpm for the arm64 architecture as well. You can just copy how it's done for .deb.

[hicom150]

Done! 👍

[feross]

LGTM. We should test the built files on Red Hat / CentOS before merging this.

[feross]

I tried building this and ran into these issues:

• The Homebrew system dep is called rpm, not rpmbuild. Changing this allowed me to build successfully.

• When double-clicking on the .rpm file in CentOS, I get the following error:

[hicom150]

Thank you @feross for the feedback 😉

The Homebrew system dep is called rpm, not rpmbuild. Changing this allowed me to build successfully.

Nice catch, changed! 👍

When double-clicking on the .rpm file in CentOS, I get the following error

Could you try with yum install to check what could be the error cause?

In the other hand, I also try to install in a VM with Fedora 30 and get a "incompatible architecture" error. So I can guess that for RedHat based distributions we have to set destArch='x86_64' and for Debian based ones destArch='amd64'.

I commit this last change so we can test that this assumption is right for all the different distributions 😅

[feross]

Ahh, I was getting a "Cannot find a valid baseurl for repo: base/7/x86_64" error which I think means yum couldn't reach the internet. Weird that it needs to do that to install a local .rpm file. Anyway, I resolved that. Now I get:

Loaded plugins: fastestmirror, langpacks
Examining /home/feross/Desktop/webtorrent-desktop-0.21.0-1.x86_64.rpm: webtorrent-desktop-0.21.0-1.x86_64
Marking /home/feross/Desktop/webtorrent-desktop-0.21.0-1.x86_64.rpm to be installed
Resolving Dependencies
--> Running transaction check
---> Package webtorrent-desktop.x86_64 0:0.21.0-1 will be installed
--> Processing Dependency: (kde-cli-tools or kde-runtime or trash-cli or glib2 or gvfs-client) for package: webtorrent-desktop-0.21.0-1.x86_64
Loading mirror speeds from cached hostfile
 * base: mirror.sjc02.svwh.net
 * extras: mirror.sjc02.svwh.net
 * updates: mirror.sjc02.svwh.net
base                                                     | 3.6 kB     00:00     
extras                                                   | 2.9 kB     00:00     
updates                                                  | 2.9 kB     00:00     
updates/7/x86_64/primary_db                                | 1.1 MB   00:00     
--> Processing Dependency: libXScrnSaver for package: webtorrent-desktop-0.21.0-1.x86_64
--> Running transaction check
---> Package libXScrnSaver.x86_64 0:1.2.2-6.1.el7 will be installed
---> Package webtorrent-desktop.x86_64 0:0.21.0-1 will be installed
--> Processing Dependency: (kde-cli-tools or kde-runtime or trash-cli or glib2 or gvfs-client) for package: webtorrent-desktop-0.21.0-1.x86_64
--> Finished Dependency Resolution
Error: Package: webtorrent-desktop-0.21.0-1.x86_64 (/webtorrent-desktop-0.21.0-1.x86_64)
           Requires: (kde-cli-tools or kde-runtime or trash-cli or glib2 or gvfs-client)
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest

Is this something we can resolve with how we produce the .rpm file?

[hicom150]

After some investigation, I found that electron-installer-redhat has the requirement of having rpm > 4.13 and that is why we can install successfully in Fedora and fails in CentOS 😓

I don't know what next steps should we take... Any suggestions?

[mathiasvr]

We could just make a notice that it is a requirement to have rpm > 4.13 to use the installer?
I don't think it's worth it to try and support older versions unless someone would like to do it.

I don't know much about snap packages, but is there any chance that would work as an alternative?

[feross]

We could just make a notice that it is a requirement to have rpm > 4.13 to use the installer?

Yeah, this sounds good to me. Right now there's no .rpm support at all, so this is an improvement :)

We should probably make a page with detailed installation options for all the different OSes. Even on Mac, it's possible to install via Homebrew casks, and there's lots of options on Linux. I made an issue about this: #1706