Repository navigation
Bug Fix Empty Array Reduce - #1494
Merged
Merged
Conversation
|
🙌 Thanks for opening this pull request! You're awesome. |
mathiasvr
reviewed
Oct 7, 2018
mathiasvr
approved these changes
Oct 7, 2018
mathiasvr
reviewed
Oct 7, 2018
|
|
||
| const mediaExtensions = require('./media-extensions') | ||
|
|
||
| const msgNoSuitablePoster = 'Cannot generate a poster from any files in the torrent' |
Contributor
There was a problem hiding this comment.
Good call @Borewit, could you actually move this to /src/renderer/lib/errors.js?
Borewit
approved these changes
Oct 7, 2018
| function torrentPosterFromAudio (torrent, cb) { | ||
| const imageFiles = filterOnExtension(torrent, mediaExtensions.image) | ||
|
|
||
| if (imageFiles.length === 0) return cb(new Error('Generated poster contains no files')) |
Member
There was a problem hiding this comment.
The purpose of this routine is to find a suitable image to be used as a poster. So without files, there is no poster. Error message maybe something like "could not find a suitable image to generate an audio poster".
|
🎉 Congrats on getting your first pull request landed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1436
This PR fixes a small Type Error where
filterOnExtensionmight return an empty array which will be operated by a map and reduce function. This will cause the reduce function to print out the Type Error. The suggested fix is to check for the empty array and return an Error.