Repository navigation
fix(create-rspress): add TypeScript dependency to templates - #3525
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a scaffolding gap in packages/create-rspress where generated templates include TypeScript configuration but did not include typescript itself, leading to projects without a local TypeScript toolchain. It adds typescript to the shared template devDependencies and adds a regression assertion to ensure future scaffolds include it.
Changes:
- Add
typescripttotemplate-commondevDependencies so generated projects have a local TS toolchain. - Extend the scaffold regression test to assert
typescriptis present in the generatedpackage.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/create-rspress/tests/cli-scaffold.test.ts | Adds an assertion that the scaffolded project’s devDependencies includes typescript. |
| packages/create-rspress/template-common/package.json | Adds typescript to shared template devDependencies used during scaffolding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SoonIter
enabled auto-merge (squash)
July 16, 2026 07:34
Timeless0911
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The initial create-rspress templates include TypeScript configuration but omit TypeScript itself, so generated projects do not have a local TypeScript toolchain. This PR adds TypeScript to the shared template devDependencies and covers the generated package manifest with a scaffold regression assertion.
Related Issue
N/A
Checklist