[release-1.14] fix: fall back minAvailable to replicas when partition minPartitions is omitted - #5459
Merged
volcano-sh-bot merged 2 commits intoJun 18, 2026
Conversation
Copilot
AI
changed the title
[WIP] Fix fall back minAvailable to replicas when partition minPartitions is omitted
[release-1.14] fix: fall back minAvailable to replicas when partition minPartitions is omitted
Jun 16, 2026
JesseStutler
marked this pull request as ready for review
June 16, 2026 12:13
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #5402 to
release-1.14(automated cherry-pick failed due to test struct differences).When
PartitionPolicyis set butMinPartitionsis omitted (defaults to 0), the mutate webhook computedMinAvailable = 0 * PartitionSize = 0, silently dropping the task's gang scheduling guarantee. The validate webhook then rejected the corrected value because0 != MinAvailable.Changes
mutate_job.go— Gate partition-derivedMinAvailableonMinPartitions > 0; otherwise fall back toReplicasadmit_job.go— SkipMinAvailable == MinPartitions*PartitionSizevalidation whenMinPartitionsis 0mutate_job_test.go— Fix existing expectation (MinAvailable= 1 not 0) and add regression testadmit_job_test.go— Add regression test (adapted to release-1.14 test struct which lacksPodLevelResourcesEnabled)