[release-1.15] fix: fall back minAvailable to replicas when partition minPartitions is omitted - #5456
Conversation
…is omitted Signed-off-by: Junhao Zou <zoujh99@qq.com>
volcano-sh-bot
added
the
size/L
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses issue #5401 by ensuring that when a task's PartitionPolicy is set but MinPartitions is omitted (defaulting to 0), MinAvailable falls back to Replicas instead of defaulting to 0, which would silently drop the task's gang guarantee. The validation logic has been updated to skip enforcing the relationship between MinAvailable and MinPartitions when MinPartitions is not explicitly set (> 0). Additionally, regression tests have been added to verify this behavior in both mutation and validation webhooks. No review comments were provided, so there is no feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
3 participants
This is an automated cherry-pick of #5402