[release-1.14] Stabilize predicates plugin execution order and rollback semantics - #5286
Merged
volcano-sh-bot merged 2 commits intoMay 8, 2026
Conversation
Agent-Logs-Url: https://github.com/volcano-sh/volcano/sessions/b482491c-5d85-431a-967a-e7401072a5a8 Co-authored-by: JesseStutler <38534065+JesseStutler@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Stabilize predicates plugin execution order and rollback semantics
[release-1.14] Stabilize predicates plugin execution order and rollback semantics
May 8, 2026
JesseStutler
marked this pull request as ready for review
May 8, 2026 03:18
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picking #5259 onto
release-1.14required manual conflict resolution in the predicates plugin. This updates plugin execution to deterministic ordering and aligns rollback behavior with reserve execution order.Deterministic plugin execution across predicates stages
PredicatesPluginfor each stage:FilterOrder,StableFilterOrder,PreFilterOrder,ReserveOrder,PreBindOrder,ScoreOrderInitPlugin()registration via stage-specific helper adders.PrePredicate,Predicate(stable + non-stable filters),BatchNodeOrder,runReservePlugins,PreBind.Rollback semantics made symmetric with reserve path
ReserveOrderin reverse.runUnReservePlugins) andPreBindRollBackto use reverse-order unreserve execution.Naming alignment from the follow-up patch
PrefilterPlugins→PreFilterPluginsFocused test coverage for this backport