Skip to content

[release-1.13] Rollback unnecessary deepcopy in snapshot - #5186

Merged
JesseStutler merged 1 commit into
volcano-sh:release-1.13from
volcano-sh-bot:cherry-pick-5177-to-release-1.13
Apr 13, 2026
Merged

[release-1.13] Rollback unnecessary deepcopy in snapshot#5186
JesseStutler merged 1 commit into
volcano-sh:release-1.13from
volcano-sh-bot:cherry-pick-5177-to-release-1.13

Conversation

@volcano-sh-bot

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #5177

None

Signed-off-by: zhangzhifei16 <zhangzhifei16@jd.com>
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces deep copies with shallow copies for Pod and Node objects within the Clone methods of TaskInfo and NodeInfo. While this change likely aims to improve performance, a significant issue was identified in TaskInfo.Clone: removing the deep copy of the Pod object introduces potential data races and side effects on the scheduler cache, as the Pod object is modified in other methods such as SetPodResourceDecision.

Comment thread pkg/scheduler/api/job_info.go
@JesseStutler

Copy link
Copy Markdown
Member

/approve
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2026
@volcano-sh-bot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JesseStutler
Once this PR has been reviewed and has the lgtm label, please assign wangyang0616 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JesseStutler
JesseStutler merged commit c2754eb into volcano-sh:release-1.13 Apr 13, 2026
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants