[release-1.13] Rollback unnecessary deepcopy in snapshot - #5186
Conversation
Signed-off-by: zhangzhifei16 <zhangzhifei16@jd.com>
There was a problem hiding this comment.
Code Review
This pull request replaces deep copies with shallow copies for Pod and Node objects within the Clone methods of TaskInfo and NodeInfo. While this change likely aims to improve performance, a significant issue was identified in TaskInfo.Clone: removing the deep copy of the Pod object introduces potential data races and side effects on the scheduler cache, as the Pod object is modified in other methods such as SetPodResourceDecision.
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This is an automated cherry-pick of #5177