Skip to content

Simplify ep kernels installation - #19412

Merged
youkaichao merged 3 commits into
vllm-project:mainfrom
youkaichao:simplify_ep_kernels
Jun 10, 2025
Merged

Simplify ep kernels installation#19412
youkaichao merged 3 commits into
vllm-project:mainfrom
youkaichao:simplify_ep_kernels

Conversation

@youkaichao

@youkaichao youkaichao commented Jun 10, 2025

Copy link
Copy Markdown
Member

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

To simplify the installation of ep-related kernels. It follows the DeepEP PR deepseek-ai/DeepEP#201 .

Test Plan

Tested locally, since we don't have hopper machines in the ci.

Test Result

Passed

(Optional) Documentation Update

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @youkaichao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request simplifies the installation process for expert parallel (EP) kernels by reducing the number of required steps and removing the need for a separate GDRCopy build. It introduces a dedicated script for configuring necessary NVIDIA driver settings and adjusts the NVSHMEM build process to align with these changes, focusing on IBGDA support.

Highlights

  • Installation Steps Simplified: Reduced the required installation steps for EP kernels from 3 to 2, streamlining the process.
  • GDRCopy Build Removed: Eliminated the manual build and installation step for GDRCopy from the Python libraries installation script.
  • Dedicated Driver Configuration Script: Introduced a new script (configure_system_drivers.sh) specifically for configuring the NVIDIA driver to enable IBGDA.
  • NVSHMEM Build Configuration: Updated the NVSHMEM build flags to explicitly disable GDRCopy (NVSHMEM_USE_GDRCOPY=0) and IBRC support, while ensuring IBGDA support is enabled.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request simplifies the installation of EP-related kernels. The suggestions provided aim to improve the configuration script and remove a minor redundancy in the library installation script.

@houseroad houseroad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@youkaichao
youkaichao merged commit 64a9af5 into vllm-project:main Jun 10, 2025
@youkaichao
youkaichao deleted the simplify_ep_kernels branch June 10, 2025 12:06
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: youkaichao <youkaichao@gmail.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
Signed-off-by: youkaichao <youkaichao@gmail.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: youkaichao <youkaichao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants