[Multi Modal] Add an env var for message queue max chunk bytes - #19242
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
This pull request has merge conflicts that must be resolved before it can be |
|
Can you rebase? |
|
Also wondering @njhill 's thoughts? |
njhill
left a comment
There was a problem hiding this comment.
Thanks @jennyyyyzhen. I think it may be better for this kind of parameter to be an env var rather than adding to the scheduler config object. Do you think you could add it here instead: https://github.com/vllm-project/vllm/blob/main/vllm/envs.py
Partly because I think we may make other optimizations here soon which could make this unnecessary.
Also WDYT about increasing the default to e.g. 16MB so that it will cover llama4 single image at least?
|
@njhill Sure. I'll make it an env var to unblock llama4 performance. I can increase the default value if there are no other concerns. However, since we also have multi-image use cases and single-image requests may be batched together, the env var is still necessary to adjust the max chunk size. |
|
We can do both: 1) increase default value, 2) introduce an env var to config it. We can use two PRs (one PR/diff one thing) to do it or in one PR is fine. |
@houseroad yes exactly :) may as well do both in this PR? |
Signed-off-by: yZhen <yZhen@fb.com>
Signed-off-by: yZhen <yZhen@fb.com>
This reverts commit 18babdf3c7010f7ff8d629d118c0a1b5d72a064d. Signed-off-by: yZhen <yZhen@fb.com>
Signed-off-by: yZhen <yZhen@fb.com>
Signed-off-by: yZhen <yZhen@fb.com>
18ac81c to
3b1e5e7
Compare
|
@houseroad @njhill updated PR with both 1) and 2) |
|
Looks good. |
…project#19242) Signed-off-by: yZhen <yZhen@fb.com> Co-authored-by: yZhen <yZhen@fb.com>
…project#19242) Signed-off-by: yZhen <yZhen@fb.com> Co-authored-by: yZhen <yZhen@fb.com>
…project#19242) Signed-off-by: yZhen <yZhen@fb.com> Co-authored-by: yZhen <yZhen@fb.com>
Context:
One perf bottleneck of multimodal inference is IPC. vLLM uses shared memory to broadcast small data and zmq to broadcast large data. Currently, max chunk bytes are hardcoded to be 10MB, while Llama4 single image embedding size is ~11MB, which means it now uses zmq to broadcast input. An easy way to improve multimodal perf is to increase max chunk bytes size and use shared mem.
server
benchmark
100Mb max chunk bytes
10 Mb max chunk bytes (baseline)