Skip to content

[Bugfix] Fix misleading information in the documentation - #18845

Merged
vllm-bot merged 6 commits into
vllm-project:mainfrom
jeejeelee:fix-doc-error
May 29, 2025
Merged

[Bugfix] Fix misleading information in the documentation#18845
vllm-bot merged 6 commits into
vllm-project:mainfrom
jeejeelee:fix-doc-error

Conversation

@jeejeelee

Copy link
Copy Markdown
Member

There appears to be an issue with the model support for LoRA and PP in the documentation. Many models actually don't support LoRA. I will verify whether all models support LoRA and PP, and correct these errors

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
jeejeelee requested a review from hmellor as a code owner May 28, 2025 16:21
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jeejeelee
jeejeelee marked this pull request as draft May 28, 2025 16:22
@mergify mergify Bot added the documentation Improvements or additions to documentation label May 28, 2025
jeejeelee added 3 commits May 28, 2025 17:24
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
jeejeelee requested a review from DarkLight1337 May 29, 2025 02:25
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
jeejeelee marked this pull request as ready for review May 29, 2025 02:36
@DarkLight1337

Copy link
Copy Markdown
Member

Thanks for fixing!

@vllm-bot
vllm-bot merged commit 7fcfd95 into vllm-project:main May 29, 2025
@jeejeelee
jeejeelee deleted the fix-doc-error branch May 29, 2025 10:14
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
…t#18845)

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: amit <amit.man@gmail.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants