Skip to content

[Deprecation] Remove inputs arg fallback in Engine classes - #18799

Merged
DarkLight1337 merged 4 commits into
vllm-project:mainfrom
DarkLight1337:deprecate-inputs-arg
Jun 9, 2025
Merged

[Deprecation] Remove inputs arg fallback in Engine classes#18799
DarkLight1337 merged 4 commits into
vllm-project:mainfrom
DarkLight1337:deprecate-inputs-arg

Conversation

@DarkLight1337

@DarkLight1337 DarkLight1337 commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This is V0 code and has been deprecated since #8876, it should be safe to remove.

@DarkLight1337
[Deprecation] Remove inputs arg fallback
77d694c 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
DarkLight1337 requested a review from zhuohan123 as a code owner May 28, 2025 03:32
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
DarkLight1337
DarkLight1337 commented May 28, 2025
View reviewed changes
Comment thread vllm/engine/async_llm_engine.py
tokenizer=await self.get_tokenizer_async(lora_request),
default_guided_backend=self.decoding_config.
guided_decoding_backend,
default_guided_backend=self.decoding_config.backend,

@DarkLight1337 DarkLight1337 May 28, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves a deprecation from #17008

@github-actions

github-actions Bot commented May 28, 2025

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 changed the title [Deprecation] Remove inputs arg fallback [Deprecation] Remove inputs arg fallback in Engine classes May 28, 2025
@mergify

mergify Bot commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @DarkLight1337.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Jun 4, 2025
@DarkLight1337
Merge branch 'main' into deprecate-inputs-arg
b8769ba 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@mergify mergify Bot removed the needs-rebase label Jun 6, 2025
njhill
njhill approved these changes Jun 6, 2025
View reviewed changes

@njhill njhill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DarkLight1337

Might be a good idea to include these in the release notes

@DarkLight1337
DarkLight1337 merged commit e31ae3d into vllm-project:main Jun 9, 2025
@DarkLight1337
DarkLight1337 deleted the deprecate-inputs-arg branch June 9, 2025 02:19
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
@DarkLight1337
[Deprecation] Remove inputs arg fallback in Engine classes (vllm-pr…
85d0884 
…oject#18799)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
@DarkLight1337
[Deprecation] Remove inputs arg fallback in Engine classes (vllm-pr…
18ef514 
…oject#18799)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
@DarkLight1337
[Deprecation] Remove inputs arg fallback in Engine classes (vllm-pr…
e20ccb6 
…oject#18799)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njhill njhill njhill approved these changes
@youkaichao youkaichao youkaichao approved these changes
@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat
@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123
@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat
@comaniac comaniac Awaiting requested review from comaniac

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DarkLight1337 @njhill @youkaichao