Skip to content

decrement server_load on listen for disconnect - #18784

Merged
DarkLight1337 merged 1 commit into
vllm-project:mainfrom
daniel-salib:server-load-decrement-on-disconnect
May 28, 2025
Merged

decrement server_load on listen for disconnect#18784
DarkLight1337 merged 1 commit into
vllm-project:mainfrom
daniel-salib:server-load-decrement-on-disconnect

Conversation

@daniel-salib

Copy link
Copy Markdown
Contributor

the background task to decrement server_load can only trigger if there's a response. If the connection is terminated (i.e. canceled or timeout), then we need to ensure server load is decremented elsewhere

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify Bot added the frontend label May 28, 2025
@daniel-salib
daniel-salib marked this pull request as ready for review May 28, 2025 04:47

@houseroad houseroad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
@houseroad
houseroad enabled auto-merge (squash) May 28, 2025 07:49
Signed-off-by: Daniel Salib <danielsalib@meta.com>
auto-merge was automatically disabled May 28, 2025 08:06

Head branch was pushed to by a user without write access

@DarkLight1337
DarkLight1337 merged commit 6e4cea1 into vllm-project:main May 28, 2025
@facebook-github-bot

Copy link
Copy Markdown

@daniel-salib has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
Signed-off-by: Daniel Salib <danielsalib@meta.com>
Signed-off-by: amit <amit.man@gmail.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: Daniel Salib <danielsalib@meta.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
Signed-off-by: Daniel Salib <danielsalib@meta.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: Daniel Salib <danielsalib@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants