decrement server_load on listen for disconnect - #18784
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Daniel Salib <danielsalib@meta.com>
Head branch was pushed to by a user without write access
|
@daniel-salib has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Signed-off-by: Daniel Salib <danielsalib@meta.com> Signed-off-by: amit <amit.man@gmail.com>
Signed-off-by: Daniel Salib <danielsalib@meta.com>
Signed-off-by: Daniel Salib <danielsalib@meta.com>
Signed-off-by: Daniel Salib <danielsalib@meta.com>
the background task to decrement server_load can only trigger if there's a response. If the connection is terminated (i.e. canceled or timeout), then we need to ensure server load is decremented elsewhere