[V1] fix torch profiling for V1 offline scenarios - #18445
Conversation
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
|
Can you merge from main to fix CI? |
@DarkLight1337 Hi, anything else required here? |
|
Docker build previously failed, retrying now |
Signed-off-by: Divakar Verma <divakar.verma@amd.com> Signed-off-by: amit <amit.man@gmail.com>
|
Why remove the default profile dir? IMO the default worked fine, and we should restore it so |
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Signed-off-by: Divakar Verma <divakar.verma@amd.com>
Currently, the torch profiler doesn't capture anything useful for V1 offline benchmarking scenarios as the gpu_worker is attached to a different process. This PR:
--profile-result-dirand checks if theVLLM_TORCH_PROFILER_DIRenvironment variable is set before enabling profiling