Skip to content

[V1][Bugfix] Fix oracle for device checking - #15104

Merged
DarkLight1337 merged 3 commits into
mainfrom
fallback-cpu-v1
Mar 19, 2025
Merged

[V1][Bugfix] Fix oracle for device checking#15104
DarkLight1337 merged 3 commits into
mainfrom
fallback-cpu-v1

Conversation

@ywang96

@ywang96 ywang96 commented Mar 19, 2025

Copy link
Copy Markdown
Member

Only AMD & TPU are experimental support on V1, and all other devices will simply error out on V1, so this PR adds this logic explicitly.

FIXES #15057

Signed-off-by: Roger Wang <ywang@roblox.com>
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

ywang96 added 2 commits March 19, 2025 00:34
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 19, 2025
@DarkLight1337
DarkLight1337 merged commit dafb4e5 into main Mar 19, 2025
@DarkLight1337
DarkLight1337 deleted the fallback-cpu-v1 branch March 19, 2025 10:35
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: Roger Wang <ywang@roblox.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
Signed-off-by: Roger Wang <ywang@roblox.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: Roger Wang <ywang@roblox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SmolVLM / Idefics3 model with V1 crash

2 participants