Skip to content

[Bugfix] Fix interface for Olmo2 on V1 - #14976

Merged
vllm-bot merged 2 commits into
mainfrom
olmo2-v1
Mar 17, 2025
Merged

[Bugfix] Fix interface for Olmo2 on V1#14976
vllm-bot merged 2 commits into
mainfrom
olmo2-v1

Conversation

@ywang96

@ywang96 ywang96 commented Mar 17, 2025

Copy link
Copy Markdown
Member

FIXES #14975

@ywang96
fix interface
62b56f4 
Signed-off-by: Roger Wang <ywang@roblox.com>
@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 17, 2025
@ywang96 ywang96 added this to the v0.8.0 milestone Mar 17, 2025
@ywang96
fix sampler
fe66a82 
Signed-off-by: Roger Wang <ywang@roblox.com>
tlrmchlsmth
tlrmchlsmth approved these changes Mar 17, 2025
View reviewed changes

@tlrmchlsmth tlrmchlsmth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vllm-bot
vllm-bot merged commit 5340b0e into main Mar 17, 2025
@vllm-bot
vllm-bot deleted the olmo2-v1 branch March 17, 2025 18:26
simon-mo pushed a commit that referenced this pull request Mar 17, 2025
@ywang96 @simon-mo
[Bugfix] Fix interface for Olmo2 on V1 (#14976)
5ac1a8e 
Signed-off-by: Roger Wang <ywang@roblox.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@ywang96 @lulmer
[Bugfix] Fix interface for Olmo2 on V1 (vllm-project#14976)
b552984 
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@ywang96 @shreyankg
[Bugfix] Fix interface for Olmo2 on V1 (vllm-project#14976)
ab04628 
Signed-off-by: Roger Wang <ywang@roblox.com>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@ywang96 Mu Huai
[Bugfix] Fix interface for Olmo2 on V1 (vllm-project#14976)
6e1ad20 
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
@ywang96 @simon-mo
[Bugfix] Fix interface for Olmo2 on V1 (vllm-project#14976)
cf1de59 
Signed-off-by: Roger Wang <ywang@roblox.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
@ywang96
[Bugfix] Fix interface for Olmo2 on V1 (vllm-project#14976)
9844c3a 
Signed-off-by: Roger Wang <ywang@roblox.com>
philippesic pushed a commit to philippesic/vllm-semantic-cache that referenced this pull request Jul 19, 2026
@ywang96
[Bugfix] Fix interface for Olmo2 on V1 (vllm-project#14976)
3463c8a 
Signed-off-by: Roger Wang <ywang@roblox.com>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
@ywang96
[Bugfix] Fix interface for Olmo2 on V1 (vllm-project#14976)
0facc12 
Signed-off-by: Roger Wang <ywang@roblox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes
@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

v0.8.0

Development

Successfully merging this pull request may close these issues.

[Bug][V1]: allenai/OLMo-2-0325-32B-Instruct - unexpected keyword argument 'inputs_embeds'

4 participants

@ywang96 @tlrmchlsmth @DarkLight1337 @vllm-bot