fix(browser): don't redirect vitest in client environment - #10975
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
I'm gonna merge the fix to test it out in a new |
Contributor
|
That worked, thank you very much ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With inline
projects, thevitest:resolve-rootplugin redirectedvitestimports to the root server, which resolved them to raw dist files, while pre-bundled dependencies got the optimizer's copy of the runtime. The second copy has no runner state, failing any setup file that imports a package likevitest-browser-react. Both resolvers now stay out of the browserclientenvironment, so everything resolves to the pre-bundled copy.Also moves
@vitest/browser/clientfromoptimizeDeps.includetoexclude: it is not resolvable from the project root under pnpm (see theFailed to resolve dependencywarning in #10836), and the built file is self-contained, so pre-bundling it buys nothing.Closes #10944