Repository navigation
[ESLint] Support single-file linting in next lint (necessary for lint-staged) - #28042
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
next lint (necessary for lint-staged)next lint (necessary for lint-staged)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Build (Decrease detected ✓)General Overall increase
|
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| buildDuration | 15.9s | 16.9s | |
| buildDurationCached | 4.1s | 4.1s | -53ms |
| nodeModulesSize | 49.2 MB | 49.2 MB |
Page Load Tests Overall decrease ⚠️
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 3.182 | 3.143 | -0.04 |
| / avg req/sec | 785.74 | 795.31 | +9.57 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.874 | 1.972 | |
| /error-in-render avg req/sec | 1333.8 | 1267.43 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| 745.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 23.3 kB | 23.3 kB | ✓ |
| webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
| Overall change | 67.2 kB | 67.2 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 979 B | 979 B | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 329 B | 329 B | ✓ |
| dynamic-HASH.js gzip | 2.67 kB | 2.67 kB | ✓ |
| head-HASH.js gzip | 351 B | 351 B | ✓ |
| hooks-HASH.js gzip | 918 B | 918 B | ✓ |
| image-HASH.js gzip | 4.14 kB | 4.14 kB | ✓ |
| index-HASH.js gzip | 261 B | 261 B | ✓ |
| link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
| routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
| script-HASH.js gzip | 387 B | 387 B | ✓ |
| withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
| bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
| Overall change | 13 kB | 13 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 492 B | 492 B | ✓ |
| Overall change | 492 B | 492 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| index.html gzip | 539 B | 539 B | ✓ |
| link.html gzip | 553 B | 553 B | ✓ |
| withRouter.html gzip | 533 B | 533 B | ✓ |
| Overall change | 1.63 kB | 1.63 kB | ✓ |
Webpack 4 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| buildDuration | 12.8s | 12.8s | -74ms |
| buildDurationCached | 5.3s | 5.3s | -28ms |
| nodeModulesSize | 49.2 MB | 49.2 MB |
Page Load Tests Overall increase ✓
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 3.121 | 3.166 | |
| / avg req/sec | 801.14 | 789.74 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.917 | 1.873 | -0.04 |
| /error-in-render avg req/sec | 1303.93 | 1334.8 | +30.87 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| 16.HASH.js gzip | 186 B | 186 B | ✓ |
| 677f882d2ed8..HASH.js gzip | 14.1 kB | 14.1 kB | ✓ |
| framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
| main-HASH.js gzip | 10.7 kB | 10.7 kB | ✓ |
| webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
| Overall change | 68.1 kB | 68.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 964 B | 964 B | ✓ |
| _error-HASH.js gzip | 3.8 kB | 3.8 kB | ✓ |
| amp-HASH.js gzip | 552 B | 552 B | ✓ |
| css-HASH.js gzip | 333 B | 333 B | ✓ |
| dynamic-HASH.js gzip | 2.87 kB | 2.87 kB | ✓ |
| head-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
| hooks-HASH.js gzip | 924 B | 924 B | ✓ |
| index-HASH.js gzip | 231 B | 231 B | ✓ |
| link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
| routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
| script-HASH.js gzip | 3.03 kB | 3.03 kB | ✓ |
| withRouter-HASH.js gzip | 295 B | 295 B | ✓ |
| 30809af5c834..565.css gzip | 125 B | 125 B | ✓ |
| Overall change | 18.1 kB | 18.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 500 B | 500 B | ✓ |
| Overall change | 500 B | 500 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | housseindjirdeh/next.js bug/#27997 | Change | |
|---|---|---|---|
| index.html gzip | 584 B | 584 B | ✓ |
| link.html gzip | 597 B | 597 B | ✓ |
| withRouter.html gzip | 577 B | 577 B | ✓ |
| Overall change | 1.76 kB | 1.76 kB | ✓ |
Failing test suitesCommit: 99c69fc test/integration/required-server-files/test/index.test.js
Expand output● Required Server Files › should output required-server-files manifest correctly ● Required Server Files › should render SSR page correctly ● Required Server Files › should render dynamic SSR page correctly ● Required Server Files › should render fallback page correctly ● Required Server Files › should render SSR page correctly with x-matched-path ● Required Server Files › should render dynamic SSR page correctly with x-matched-path ● Required Server Files › should render fallback page correctly with x-matched-path and routes-matches ● Required Server Files › should return data correctly with x-matched-path ● Required Server Files › should render fallback optional catch-all route correctly with x-matched-path and routes-matches ● Required Server Files › should return data correctly with x-matched-path for optional catch-all route ● Required Server Files › should not apply trailingSlash redirect ● Required Server Files › should normalize catch-all rewrite query values correctly ● Required Server Files › should bubble error correctly for gip page ● Required Server Files › should bubble error correctly for gssp page ● Required Server Files › should bubble error correctly for gsp page ● Required Server Files › should bubble error correctly for API page ● Required Server Files › should normalize optional values correctly for SSP page ● Required Server Files › should normalize optional values correctly for SSG page ● Required Server Files › should normalize optional values correctly for SSG page with encoded slash ● Required Server Files › should normalize optional values correctly for API page ● Required Server Files › should match the index page correctly ● Required Server Files › should match the root dyanmic page correctly |
|
Great new feature @housseindjirdeh – I was just looking for it 😍 In your markdown example you suggest to
In my ‘classic’ ESLint projects I configure ## extensions
# 1. ignore all files
# 2. un-ignore files with ceratin extensions
## same as in .gitignore
...See example. This allows me to call With |
|
Thanks @kachkaev, and appreciate the feedback :)
Hmm do you have an idea of were you would like to provide a list of ignored files? Because an option could be to leverage One note: it seems that Let me know what you think, or if there's something that we can/should be doing! |
Supports single-file linting in
next lintwith the--fileflag. Also fixes #27997 by providinglint-stagedsupport.Note: This adds the same functionality that was added in #26777 but without introducing any breaking changes