Repository navigation
fix(turbopack): evaluate pure constructor callees - #100588
Merged
Merged
Conversation
github-actions
Bot
added
created-by: Turbopack team
Contributor
Tests PassedCommit: e078dfc |
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
mischnic
force-pushed
the
fleet/side-effects-constructor-callee
branch
from
October 22, 2026 14:37
a630a99 to
e078dfc
Compare
mischnic
marked this pull request as ready for review
October 22, 2026 15:19
lukesandberg
approved these changes
Oct 22, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve effects from evaluating a constructor callee even when construction is PURE-annotated. For example,
/*#__PURE__*/ new (getConstructor())()must account for callinggetConstructor().Visit the callee before arguments, matching pure call handling. Add analyzer and execution regressions while preserving upstream PURE callback handling from #100577.
Independent of the callback stack (#100586 / #100587); rebase whichever lands later if their
Expr::Newedits overlap.Verification
turbopack-ecmascriptlibrary: 609 tests passed.