Repository navigation
[test] Cover cache sharing after handler failures - #100519
Merged
Merged
Conversation
unstubbable
added this pull request to stack #100520
October 21, 2026 15:06
Contributor
Tests PassedCommit: 30f615d |
github-actions
Bot
added
created-by: Next.js team
unstubbable
force-pushed
the
hl/use-cache-handler-failure-tests
branch
2 times, most recently
from
October 22, 2026 09:53
3ab8e8f to
5f805e3
Compare
The existing handler-error tests cover error reporting and rendering after a failed write. The new tests also cover intra-request lookup retries and a joiner that needs a different root key after the producer's write fails. A held write verifies that the retried calls can consume the same generated value before persistence finishes. The root-param case verifies that the joiner persists and reuses its own value. Both cases pass before the wrapper rewrite in #100511.
unstubbable
force-pushed
the
hl/use-cache-handler-failure-tests
branch
from
October 22, 2026 10:41
5f805e3 to
30f615d
Compare
unstubbable
marked this pull request as ready for review
October 22, 2026 15:06
lubieowoce
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing handler-error tests cover error reporting and rendering after a failed write. The new tests also cover intra-request lookup retries and a joiner that needs a different root key after the producer's write fails.
A held write verifies that the retried calls can consume the same generated value before persistence finishes. The root-param case verifies that the joiner persists and reuses its own value. Both cases pass before the wrapper rewrite in #100511.