Repository navigation
test: enable build-error suites in deploy mode - #100482
Merged
jamiboym merged 5 commits intoOct 23, 2026
Merged
Conversation
Contributor
Tests PassedCommit: 284440b |
jamiboym
force-pushed
the
jamiboym/enable-deploy/cache-components-build-errors
branch
from
October 21, 2026 00:00
bd332a9 to
1750bcc
Compare
jamiboym
marked this pull request as ready for review
October 23, 2026 16:56
jamiboym
deleted the
jamiboym/enable-deploy/cache-components-build-errors
branch
October 23, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables five suites in deploy mode whose builds are expected to fail, or whose setup used
patchFileor a runtime-only env.use-cache-unknown-cache-kind,use-cache-without-experimental-flag,proxy-and-middleware-conflict: outside dev the tests assertnext.start()rejects and read the build diagnostics fromnext.cliOutput, withtoContainchecks in deploy mode and the existing snapshots locally. The first two previously branched onisNextStart, so in deploy mode their dev-onlycreateSandboxtests ran instead.proxy-and-middleware-conflictdrops its blanketskipDeployment.cache-components-segment-configs: samenext.start()rejection pattern. The layout-propagation test usednext.patchFile('app/layout.tsx', âĶ), which deploy mode doesn't support. It now has its ownnextTestSetupwhoseoverrideFilesswaps infixtures/layout-runtime/app/layout.tsx. The Turbopack location assertion moves from./app/layout.tsx:2:24to:1:14to match the fixture file.cache-components-errors/console-patch: with the gate removed in the Sept 9 retry runs, the deployment failed becauseNODE_OPTIONS='--require ./patch-console.js'is forwarded as both a build and a runtime env, and Vercel's own CLI process crashed withCannot find module './patch-console.js'. In deploy mode the preload is now scoped to the build viabuildCommand; dev and start keepenv. The deploy branch asserts the deployment succeeds (so the build didn't fail on the patchedconsole.log) and that the patched log line appears in the build output. The local snapshots are unchanged.Verification
next devandnext start, with Turbopack and with webpackNEXT_ENABLE_ADAPTER=0); my account lacks deploy access to the Turbopack test team's project.