Skip to content

test: enable build-error suites in deploy mode - #100482

Merged
jamiboym merged 5 commits into
canaryfrom
jamiboym/enable-deploy/cache-components-build-errors
Oct 23, 2026
Merged

jamiboym merged 5 commits into
canaryfrom
jamiboym/enable-deploy/cache-components-build-errors

Conversation

@jamiboym

@jamiboym jamiboym commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Enables five suites in deploy mode whose builds are expected to fail, or whose setup used patchFile or a runtime-only env.

  • use-cache-unknown-cache-kind, use-cache-without-experimental-flag, proxy-and-middleware-conflict: outside dev the tests assert next.start() rejects and read the build diagnostics from next.cliOutput, with toContain checks in deploy mode and the existing snapshots locally. The first two previously branched on isNextStart, so in deploy mode their dev-only createSandbox tests ran instead. proxy-and-middleware-conflict drops its blanket skipDeployment.
  • cache-components-segment-configs: same next.start() rejection pattern. The layout-propagation test used next.patchFile('app/layout.tsx', â€Ķ), which deploy mode doesn't support. It now has its own nextTestSetup whose overrideFiles swaps in fixtures/layout-runtime/app/layout.tsx. The Turbopack location assertion moves from ./app/layout.tsx:2:24 to :1:14 to match the fixture file.
  • cache-components-errors/console-patch: with the gate removed in the Sept 9 retry runs, the deployment failed because NODE_OPTIONS='--require ./patch-console.js' is forwarded as both a build and a runtime env, and Vercel's own CLI process crashed with Cannot find module './patch-console.js'. In deploy mode the preload is now scoped to the build via buildCommand; dev and start keep env. The deploy branch asserts the deployment succeeds (so the build didn't fail on the patched console.log) and that the patched log line appears in the build output. The local snapshots are unchanged.

Verification

  • Prettier and ESLint on the changed files.
  • Ran all five suites locally against this branch's local packages; every suite passed in each of:
    • next dev and next start, with Turbopack and with webpack
    • deploy, Turbopack + adapter (the PR deploy job's variant)
    • deploy, Webpack legacy (one of the release workflow's variants)
  • Not run: Turbopack legacy deploy (NEXT_ENABLE_ADAPTER=0); my account lacks deploy access to the Turbopack test team's project.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 284440b

@github-actions github-actions Bot added the tests label Oct 20, 2026
@jamiboym jamiboym changed the title test: enable cache components build-error suites in deploy mode test: enable build-error suites in deploy mode Oct 20, 2026
@jamiboym
jamiboym force-pushed the jamiboym/enable-deploy/cache-components-build-errors branch from bd332a9 to 1750bcc Compare October 21, 2026 00:00
@jamiboym
jamiboym requested a review from eps1lon October 21, 2026 21:53

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dddd

@jamiboym
jamiboym marked this pull request as ready for review October 23, 2026 16:56
@jamiboym
jamiboym merged commit 8b58388 into canary Oct 23, 2026
121 checks passed
@jamiboym
jamiboym deleted the jamiboym/enable-deploy/cache-components-build-errors branch October 23, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants