Repository navigation
Fix Activity testing guide claim about label and placeholder locators - #100445
Merged
Merged
Conversation
Contributor
Tests PassedCommit: 6bccaa8 |
icyJoseph
marked this pull request as ready for review
October 20, 2026 12:59
molebox
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Testing section of the Preserving UI state guide said Playwright
getByLabelandgetByPlaceholderfilter by visibility. They do not: with Activity keeping a hidden page in the DOM, both locators match the hidden copy and.fill()fails with a strict mode violation. OnlygetByRoleexcludes hidden elements by default.getByRoleas the default Playwright examplegetByLabel/getByPlaceholderinto the explicit.filter({ visible: true })examplescy.get()option, and point readers to their testing tool's locator and helper docs, since this behavior varies between tools and versionsVerification
display: nonecopy:getByLabelmatched 3,getByPlaceholdermatched 2 (both strict mode violations on.fill());getByRoleand the.filter({ visible: true })variants each matched 1